From: Karthik Nayak <karthik.188@gmail.com>
To: git@vger.kernel.org
Cc: matthieu.moy@grenoble-inp.fr, gitster@pobox.com,
Karthik Nayak <Karthik.188@gmail.com>
Subject: [PATCH/RFC 01/10] ref-filter: introduce a parsing function for each atom in valid_atom
Date: Thu, 12 Nov 2015 01:14:27 +0530 [thread overview]
Message-ID: <1447271075-15364-2-git-send-email-Karthik.188@gmail.com> (raw)
In-Reply-To: <1447271075-15364-1-git-send-email-Karthik.188@gmail.com>
Introduce a parsing function for each atom in valid_atom. Using this
we can define special parsing functions for each of the atoms. Since
we have a third field in valid_atom structure, we now fill out missing
cmp_type values.
Signed-off-by: Karthik Nayak <Karthik.188@gmail.com>
---
ref-filter.c | 59 ++++++++++++++++++++++++++++++-----------------------------
1 file changed, 30 insertions(+), 29 deletions(-)
diff --git a/ref-filter.c b/ref-filter.c
index e205dd2..fbbda17 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -19,42 +19,43 @@ typedef enum { FIELD_STR, FIELD_ULONG, FIELD_TIME } cmp_type;
static struct {
const char *name;
cmp_type cmp_type;
+ void (*parser)(struct used_atom *atom);
} valid_atom[] = {
- { "refname" },
- { "objecttype" },
+ { "refname", FIELD_STR },
+ { "objecttype", FIELD_STR },
{ "objectsize", FIELD_ULONG },
- { "objectname" },
- { "tree" },
- { "parent" },
+ { "objectname", FIELD_STR },
+ { "tree", FIELD_STR },
+ { "parent", FIELD_STR },
{ "numparent", FIELD_ULONG },
- { "object" },
- { "type" },
- { "tag" },
- { "author" },
- { "authorname" },
- { "authoremail" },
+ { "object", FIELD_STR },
+ { "type", FIELD_STR },
+ { "tag", FIELD_STR },
+ { "author", FIELD_STR },
+ { "authorname", FIELD_STR },
+ { "authoremail", FIELD_STR },
{ "authordate", FIELD_TIME },
- { "committer" },
- { "committername" },
- { "committeremail" },
+ { "committer", FIELD_STR },
+ { "committername", FIELD_STR },
+ { "committeremail", FIELD_STR },
{ "committerdate", FIELD_TIME },
- { "tagger" },
- { "taggername" },
- { "taggeremail" },
+ { "tagger", FIELD_STR },
+ { "taggername", FIELD_STR },
+ { "taggeremail", FIELD_STR },
{ "taggerdate", FIELD_TIME },
- { "creator" },
+ { "creator", FIELD_STR },
{ "creatordate", FIELD_TIME },
- { "subject" },
- { "body" },
- { "contents" },
- { "upstream" },
- { "push" },
- { "symref" },
- { "flag" },
- { "HEAD" },
- { "color" },
- { "align" },
- { "end" },
+ { "subject", FIELD_STR },
+ { "body", FIELD_STR },
+ { "contents", FIELD_STR },
+ { "upstream", FIELD_STR },
+ { "push", FIELD_STR },
+ { "symref", FIELD_STR },
+ { "flag", FIELD_STR },
+ { "HEAD", FIELD_STR },
+ { "color", FIELD_STR },
+ { "align", FIELD_STR },
+ { "end", FIELD_STR },
};
#define REF_FORMATTING_STATE_INIT { 0, NULL }
--
2.6.2
next prev parent reply other threads:[~2015-11-11 19:44 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 19:44 [PATCH/RFC 00/10] ref-filter: use parsing functions Karthik Nayak
2015-11-11 19:44 ` Karthik Nayak [this message]
2015-11-23 23:44 ` [PATCH/RFC 01/10] ref-filter: introduce a parsing function for each atom in valid_atom Eric Sunshine
2015-11-25 12:10 ` Karthik Nayak
2015-11-25 19:41 ` Eric Sunshine
2015-11-26 18:01 ` Karthik Nayak
2015-12-11 22:18 ` Junio C Hamano
2015-12-12 16:05 ` Karthik Nayak
2015-11-11 19:44 ` [PATCH/RFC 02/10] ref-filter: introduce struct used_atom Karthik Nayak
2015-12-01 23:00 ` Eric Sunshine
2015-11-11 19:44 ` [PATCH/RFC 03/10] ref-fitler: bump match_atom() name to the top Karthik Nayak
2015-11-11 19:44 ` [PATCH/RFC 04/10] ref-filter: skip deref specifier in match_atom_name() Karthik Nayak
2015-12-01 23:11 ` Eric Sunshine
2015-12-03 6:34 ` Karthik Nayak
2015-11-11 19:44 ` [PATCH/RFC 05/10] ref-filter: introduce color_atom_parser() Karthik Nayak
2015-12-01 23:27 ` Eric Sunshine
2015-12-03 13:35 ` Karthik Nayak
2015-12-13 6:05 ` Eric Sunshine
2015-12-13 18:46 ` Karthik Nayak
2015-11-11 19:44 ` [PATCH/RFC 06/10] strbuf: introduce strbuf_split_str_without_term() Karthik Nayak
2015-12-02 8:04 ` Eric Sunshine
2015-12-03 18:12 ` Karthik Nayak
2015-12-11 22:31 ` Junio C Hamano
2015-12-12 16:04 ` Karthik Nayak
2015-11-11 19:44 ` [PATCH/RFC 07/10] ref-filter: introduce align_atom_parser() Karthik Nayak
2015-12-02 21:23 ` Eric Sunshine
2015-12-07 17:00 ` Karthik Nayak
2015-11-11 19:44 ` [PATCH/RFC 08/10] ref-filter: introduce remote_ref_atom_parser() Karthik Nayak
2015-12-13 0:53 ` Eric Sunshine
2015-12-13 6:02 ` Karthik Nayak
2015-12-13 6:15 ` Eric Sunshine
2015-12-13 8:32 ` Karthik Nayak
2015-12-13 8:45 ` Eric Sunshine
2015-12-13 8:53 ` Karthik Nayak
2015-11-11 19:44 ` [PATCH/RFC 09/10] ref-filter: introduce contents_atom_parser() Karthik Nayak
2015-12-13 3:10 ` Eric Sunshine
2015-12-13 4:41 ` Eric Sunshine
2015-12-13 19:36 ` Karthik Nayak
2015-12-13 19:33 ` Karthik Nayak
2015-11-24 21:48 ` [PATCH/RFC 00/10] ref-filter: use parsing functions Jeff King
2015-11-25 12:07 ` Karthik Nayak
2015-11-25 13:44 ` [PATCH/RFC 10/10] ref-filter: introduce objectname_atom_parser() Karthik Nayak
2015-12-13 4:49 ` Eric Sunshine
2015-12-13 19:40 ` Karthik Nayak
2015-12-11 22:49 ` [PATCH/RFC 00/10] ref-filter: use parsing functions Junio C Hamano
2015-12-13 5:40 ` Eric Sunshine
2015-12-13 9:31 ` Karthik Nayak
2015-12-13 21:55 ` Eric Sunshine
2015-12-16 14:45 ` Karthik Nayak
2015-12-14 19:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447271075-15364-2-git-send-email-Karthik.188@gmail.com \
--to=karthik.188@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=matthieu.moy@grenoble-inp.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).