From: larsxschneider@gmail.com
To: git@vger.kernel.org
Cc: sbeller@google.com, Lars Schneider <larsxschneider@gmail.com>
Subject: [PATCH v1] add test to demonstrate that shallow recursive clones fail
Date: Thu, 12 Nov 2015 10:04:09 +0100 [thread overview]
Message-ID: <1447319049-51371-1-git-send-email-larsxschneider@gmail.com> (raw)
From: Lars Schneider <larsxschneider@gmail.com>
"git clone --recursive --depth 1 --single-branch <url>" clones the
submodules successfully. However, it does not obey "--depth 1" for
submodule cloning.
The following workaround does only work if the used submodule pointer
is on the default branch. Otherwise "git submodule update" fails with
"fatal: reference is not a tree:" and "Unable to checkout".
git clone --depth 1 --single-branch <url>
cd <repo-name>
git submodule update --init --recursive --depth 1
Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
---
t/t7412-submodule-recursive.sh | 64 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 64 insertions(+)
create mode 100755 t/t7412-submodule-recursive.sh
diff --git a/t/t7412-submodule-recursive.sh b/t/t7412-submodule-recursive.sh
new file mode 100755
index 0000000..c639f96
--- /dev/null
+++ b/t/t7412-submodule-recursive.sh
@@ -0,0 +1,64 @@
+#!/bin/sh
+
+test_description='Test shallow cloning of repos with submodules'
+
+. ./test-lib.sh
+
+test_expect_success setup '
+ git checkout -b master &&
+ echo file >file &&
+ git add file &&
+ test_tick &&
+ git commit -m "master commit" &&
+
+ git checkout -b branch &&
+ echo file >branch-file &&
+ git add branch-file &&
+ test_tick &&
+ git commit -m "branch commit" &&
+
+ git checkout master &&
+
+ git clone . repo &&
+ (
+ cd repo &&
+ git submodule add ../. submodule &&
+ (
+ cd submodule &&
+ git checkout branch
+ ) &&
+ git add submodule &&
+ test_tick &&
+ git commit -m "submodule"
+ )
+'
+
+test_expect_failure shallow-clone-recursive '
+ URL="file://$(pwd | sed "s/[[:space:]]/%20/g")/repo" &&
+ echo $URL &&
+ git clone --recursive --depth 1 --single-branch $URL clone-recursive &&
+ (
+ cd "clone-recursive" &&
+ git log --oneline >lines &&
+ test_line_count = 1 lines
+ ) &&
+ (
+ cd "clone-recursive/submodule" &&
+ git log --oneline >lines &&
+ test_line_count = 1 lines
+ )
+'
+
+test_expect_failure shallow-clone-recursive-workaround '
+ URL="file://$(pwd | sed "s/[[:space:]]/%20/g")/repo" &&
+ echo $URL &&
+ git clone --depth 1 --single-branch $URL clone-recursive-workaround &&
+ (
+ cd "clone-recursive-workaround" &&
+ git log --oneline >lines &&
+ test_line_count = 1 lines &&
+ git submodule update --init --recursive --depth 1
+ )
+'
+
+test_done
--
2.5.1
reply other threads:[~2015-11-12 9:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447319049-51371-1-git-send-email-larsxschneider@gmail.com \
--to=larsxschneider@gmail.com \
--cc=git@vger.kernel.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).