From: Fredrik Medley <fredrik.medley@gmail.com>
To: git@vger.kernel.org
Cc: Fredrik Medley <fredrik.medley@gmail.com>
Subject: [PATCH] rebase-i-exec: Allow space in SHELL_PATH
Date: Fri, 13 Nov 2015 07:03:19 +0100 [thread overview]
Message-ID: <1447394599-16077-1-git-send-email-fredrik.medley@gmail.com> (raw)
On Windows, when Git is installed under "C:\Program Files\Git", SHELL_PATH
will include a space. Fix "git rebase --interactive --exec" so that it
works with spaces in SHELL_PATH.
Signed-off-by: Fredrik Medley <fredrik.medley@gmail.com>
---
git-rebase--interactive.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
index 30edb17..b938a6d 100644
--- a/git-rebase--interactive.sh
+++ b/git-rebase--interactive.sh
@@ -610,7 +610,7 @@ do_next () {
read -r command rest < "$todo"
mark_action_done
printf 'Executing: %s\n' "$rest"
- ${SHELL:-@SHELL_PATH@} -c "$rest" # Actual execution
+ "${SHELL:-@SHELL_PATH@}" -c "$rest" # Actual execution
status=$?
# Run in subshell because require_clean_work_tree can die.
dirty=f
--
2.6.2.468.gf34be46.dirty
next reply other threads:[~2015-11-13 6:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-13 6:03 Fredrik Medley [this message]
2015-11-13 6:25 ` [PATCH] rebase-i-exec: Allow space in SHELL_PATH Jeff King
2015-11-13 15:25 ` Fredrik Medley
2015-11-13 22:27 ` Jeff King
2015-11-13 22:47 ` Fredrik Medley
2015-11-13 23:09 ` Jeff King
2015-11-16 16:01 ` Johannes Schindelin
2015-11-16 16:34 ` Jeff King
2015-11-13 16:52 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447394599-16077-1-git-send-email-fredrik.medley@gmail.com \
--to=fredrik.medley@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).