From: Stefan Beller <sbeller@google.com>
To: git@vger.kernel.org
Cc: ramsay@ramsayjones.plus.com, jacob.keller@gmail.com,
peff@peff.net, gitster@pobox.com, jrnieder@gmail.com,
johannes.schindelin@gmail.com, Jens.Lehmann@web.de,
ericsunshine@gmail.com, j6t@kdbg.org,
Stefan Beller <sbeller@google.com>
Subject: [PATCHv4 1/9] run_processes_parallel: delimit intermixed task output
Date: Fri, 13 Nov 2015 17:06:54 -0800 [thread overview]
Message-ID: <1447463222-12589-2-git-send-email-sbeller@google.com> (raw)
In-Reply-To: <1447463222-12589-1-git-send-email-sbeller@google.com>
This commit serves 2 purposes. First this may help the user who
tries to diagnose intermixed process calls. Second this may be used
in a later patch for testing. As the output of a command should not
change visibly except for going faster, grepping for the trace output
seems like a viable testing strategy.
Signed-off-by: Stefan Beller <sbeller@google.com>
---
run-command.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/run-command.c b/run-command.c
index 358429f..b246118 100644
--- a/run-command.c
+++ b/run-command.c
@@ -965,6 +965,9 @@ static struct parallel_processes *pp_init(int n,
n = online_cpus();
pp->max_processes = n;
+
+ trace_printf("run_processes_parallel: preparing to run up to %d tasks", n);
+
pp->data = data;
if (!get_next_task)
die("BUG: you need to specify a get_next_task function");
@@ -994,6 +997,7 @@ static void pp_cleanup(struct parallel_processes *pp)
{
int i;
+ trace_printf("run_processes_parallel: done");
for (i = 0; i < pp->max_processes; i++) {
strbuf_release(&pp->children[i].err);
child_process_clear(&pp->children[i].process);
--
2.6.3.369.gea52ac0
next prev parent reply other threads:[~2015-11-14 1:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-14 1:06 [PATCHv4 0/9] Expose submodule parallelism to the user Stefan Beller
2015-11-14 1:06 ` Stefan Beller [this message]
2015-11-14 1:06 ` [PATCHv4 2/9] submodule-config: keep update strategy around Stefan Beller
2015-11-14 1:06 ` [PATCHv4 3/9] submodule-config: drop check against NULL Stefan Beller
2015-11-14 1:06 ` [PATCHv4 4/9] submodule-config: remove name_and_item_from_var Stefan Beller
2015-11-14 1:06 ` [PATCHv4 5/9] submodule-config: introduce parse_generic_submodule_config Stefan Beller
2015-11-14 1:06 ` [PATCHv4 6/9] fetching submodules: respect `submodule.jobs` config option Stefan Beller
2015-11-14 1:07 ` [PATCHv4 7/9] git submodule update: have a dedicated helper for cloning Stefan Beller
2015-11-14 1:07 ` [PATCHv4 8/9] submodule update: expose parallelism to the user Stefan Beller
2015-11-14 1:07 ` [PATCHv4 9/9] clone: allow an explicit argument for parallel submodule clones Stefan Beller
2015-11-20 12:02 ` [PATCHv4 0/9] Expose submodule parallelism to the user Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447463222-12589-2-git-send-email-sbeller@google.com \
--to=sbeller@google.com \
--cc=Jens.Lehmann@web.de \
--cc=ericsunshine@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=jacob.keller@gmail.com \
--cc=johannes.schindelin@gmail.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).