From: Jacob Keller <jacob.e.keller@intel.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
"SZEDER Gábor" <szeder@ira.uka.de>,
"Shawn O . Pearce" <spearce@spearce.org>,
"Felipe Contreras" <felipe.contreras@gmail.com>,
"Lee Marlow" <lee.marlow@gmail.com>,
"Jacob Keller" <jacob.keller@gmail.com>
Subject: [PATCH v2 2/2] completion: add support for completing email aliases
Date: Sun, 15 Nov 2015 12:22:20 -0800 [thread overview]
Message-ID: <1447618940-27446-2-git-send-email-jacob.e.keller@intel.com> (raw)
In-Reply-To: <1447618940-27446-1-git-send-email-jacob.e.keller@intel.com>
From: Jacob Keller <jacob.keller@gmail.com>
Using the new --list-aliases option from git-send-email, add completion
for --to, --cc, and --bcc with the available configured aliases.
Signed-off-by: Jacob Keller <jacob.keller@gmail.com>
---
Notes:
- v2
* reuse parsing from git-send-email via --list-aliases
contrib/completion/git-completion.bash | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 482ca84b451b..fde246e2943e 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -10,6 +10,7 @@
# *) local and remote tag names
# *) .git/remotes file names
# *) git 'subcommands'
+# *) git email aliases for git-send-email
# *) tree paths within 'ref:path/to/file' expressions
# *) file paths within current working directory and index
# *) common --long-options
@@ -1711,6 +1712,15 @@ __git_send_email_suppresscc_options="author self cc bodycc sob cccmd body all"
_git_send_email ()
{
+ case "$prev" in
+ --to|--cc|--bcc)
+ __gitcomp "
+ $(git --git-dir="$(__gitdir)" send-email --list-aliases 2>/dev/null)
+ " "" ""
+ return
+ ;;
+ esac
+
case "$cur" in
--confirm=*)
__gitcomp "
@@ -1735,6 +1745,12 @@ _git_send_email ()
" "" "${cur##--thread=}"
return
;;
+ --to=*|--cc=*|--bcc=*)
+ __gitcomp "
+ $(git --git-dir="$(__gitdir)" send-email --list-aliases 2>/dev/null)
+ " "" "${cur#--*=}"
+ return
+ ;;
--*)
__gitcomp "--annotate --bcc --cc --cc-cmd --chain-reply-to
--compose --confirm= --dry-run --envelope-sender
--
2.6.3.491.g3e3f6ce
next prev parent reply other threads:[~2015-11-15 20:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-15 20:22 [PATCH v2 1/2] sendemail: teach git-send-email to list aliases Jacob Keller
2015-11-15 20:22 ` Jacob Keller [this message]
2015-11-16 23:33 ` [PATCH v2 2/2] completion: add support for completing email aliases Eric Sunshine
2015-11-16 23:40 ` Keller, Jacob E
2015-11-16 23:30 ` [PATCH v2 1/2] sendemail: teach git-send-email to list aliases Eric Sunshine
2015-11-16 23:40 ` Keller, Jacob E
2015-11-16 23:50 ` Eric Sunshine
2015-11-16 23:56 ` Eric Sunshine
2015-11-17 0:09 ` Keller, Jacob E
2015-11-17 0:10 ` Keller, Jacob E
2015-11-17 7:20 ` Eric Sunshine
2015-11-17 8:25 ` Jacob Keller
2015-11-17 12:26 ` SZEDER Gábor
2015-11-17 16:27 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447618940-27446-2-git-send-email-jacob.e.keller@intel.com \
--to=jacob.e.keller@intel.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jacob.keller@gmail.com \
--cc=lee.marlow@gmail.com \
--cc=spearce@spearce.org \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).