From: Jacob Keller <jacob.e.keller@intel.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
"SZEDER Gábor" <szeder@ira.uka.de>,
"Shawn O . Pearce" <spearce@spearce.org>,
"Felipe Contreras" <felipe.contreras@gmail.com>,
"Lee Marlow" <lee.marlow@gmail.com>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Jacob Keller" <jacob.keller@gmail.com>
Subject: [PATCH v3 2/2] completion: add support for completing email aliases
Date: Mon, 16 Nov 2015 16:29:26 -0800 [thread overview]
Message-ID: <1447720166-9941-2-git-send-email-jacob.e.keller@intel.com> (raw)
In-Reply-To: <1447720166-9941-1-git-send-email-jacob.e.keller@intel.com>
From: Jacob Keller <jacob.keller@gmail.com>
Using the new --dump-alias-names option from git-send-email, add completion
for --to, --cc, and --bcc with the available configured aliases.
Signed-off-by: Jacob Keller <jacob.keller@gmail.com>
---
Notes:
- v2
* Use git-send-email for parsing instead of re-implementing it in awk
- v3
* update for change to git-send-email
* add support for "--from"
contrib/completion/git-completion.bash | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 482ca84b451b..1de8c0e6fc96 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -10,6 +10,7 @@
# *) local and remote tag names
# *) .git/remotes file names
# *) git 'subcommands'
+# *) git email aliases for git-send-email
# *) tree paths within 'ref:path/to/file' expressions
# *) file paths within current working directory and index
# *) common --long-options
@@ -1709,8 +1710,25 @@ _git_reflog ()
__git_send_email_confirm_options="always never auto cc compose"
__git_send_email_suppresscc_options="author self cc bodycc sob cccmd body all"
+__git_get_email_aliases ()
+{
+ git --git-dir="$(__gitdir)" send-email --dump-aliases 2>/dev/null | while read alias expansion
+ do
+ echo $alias
+ done
+}
+
_git_send_email ()
{
+ case "$prev" in
+ --to|--cc|--bcc|--from)
+ __gitcomp "
+ $(__git_get_email_aliases)
+ " "" ""
+ return
+ ;;
+ esac
+
case "$cur" in
--confirm=*)
__gitcomp "
@@ -1735,6 +1753,12 @@ _git_send_email ()
" "" "${cur##--thread=}"
return
;;
+ --to=*|--cc=*|--bcc=*|--from=*)
+ __gitcomp "
+ $(__git_get_email_aliases)
+ " "" "${cur#--*=}"
+ return
+ ;;
--*)
__gitcomp "--annotate --bcc --cc --cc-cmd --chain-reply-to
--compose --confirm= --dry-run --envelope-sender
--
2.6.3.491.g3e3f6ce
next prev parent reply other threads:[~2015-11-17 0:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 0:29 [PATCH v3 1/2] sendemail: teach git-send-email to dump alias names Jacob Keller
2015-11-17 0:29 ` Jacob Keller [this message]
2015-11-17 8:10 ` [PATCH v3 2/2] completion: add support for completing email aliases Eric Sunshine
2015-11-17 8:07 ` [PATCH v3 1/2] sendemail: teach git-send-email to dump alias names Eric Sunshine
2015-11-17 8:32 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447720166-9941-2-git-send-email-jacob.e.keller@intel.com \
--to=jacob.e.keller@intel.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jacob.keller@gmail.com \
--cc=lee.marlow@gmail.com \
--cc=spearce@spearce.org \
--cc=sunshine@sunshineco.com \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox