[PATCH] blame: add test case for using tag object as a final ref

[PATCH] blame: add test case for using tag object as a final ref

[Max Kirillov]

It was discovered [1] that 1b0d40000a broke blaming starting from tag object.
Add test which verifies such blaming works.

[1] http://mid.gmane.org/20151117224809.GE27862@sigill.intra.peff.net

Signed-off-by: Max Kirillov <max@max630.net>
---
Thank you. Sorry, I should have noticed that obj ended up unused.

Adding test case for it. Looks ok after the fix.
 t/annotate-tests.sh | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/t/annotate-tests.sh b/t/annotate-tests.sh
index b1673b3..093832f 100644
--- a/t/annotate-tests.sh
+++ b/t/annotate-tests.sh
@@ -68,6 +68,13 @@ test_expect_success 'blame 1 author' '
 	check_count A 2
 '
 
+test_expect_success 'blame by tag objects' '
+	git tag -m "test tag" testTag &&
+	git tag -m "test tag #2" testTag2 testTag &&
+	check_count -h testTag A 2 &&
+	check_count -h testTag2 A 2
+'
+
 test_expect_success 'setup B lines' '
 	echo "2A quick brown fox jumps over the" >>file &&
 	echo "lazy dog" >>file &&
-- 
2.3.4.2801.g3d0809b

Re: [PATCH] blame: add test case for using tag object as a final ref

[Jeff King]

On Wed, Nov 18, 2015 at 07:36:32AM +0200, Max Kirillov wrote:

> It was discovered [1] that 1b0d40000a broke blaming starting from tag object.
> Add test which verifies such blaming works.
> 
> [1] http://mid.gmane.org/20151117224809.GE27862@sigill.intra.peff.net
> 
> Signed-off-by: Max Kirillov <max@max630.net>
> ---
> Thank you. Sorry, I should have noticed that obj ended up unused.

Thanks. Do you mind if I just squash this into the patch with the fix?

-Peff

Re: [PATCH] blame: add test case for using tag object as a final ref

[Max Kirillov]

On Wed, Nov 18, 2015 at 8:00 AM, Jeff King <peff@peff.net> wrote:
> On Wed, Nov 18, 2015 at 07:36:32AM +0200, Max Kirillov wrote:
>
>> It was discovered [1] that 1b0d40000a broke blaming starting from tag object.
>> Add test which verifies such blaming works.
>>
>> [1] http://mid.gmane.org/20151117224809.GE27862@sigill.intra.peff.net
>>
>> Signed-off-by: Max Kirillov <max@max630.net>
>> ---
>> Thank you. Sorry, I should have noticed that obj ended up unused.
>
> Thanks. Do you mind if I just squash this into the patch with the fix?

Not at all, please squash. 2 patches seem too many indeed

-- 
Max