From: Christian Couder <christian.couder@gmail.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>, "Jeff King" <peff@peff.net>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Nguyen Thai Ngoc Duy" <pclouds@gmail.com>,
"David Turner" <dturner@twopensource.com>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Torsten Bögershausen" <tboegi@web.de>,
"Christian Couder" <chriscool@tuxfamily.org>
Subject: [PATCH 1/8] update-index: add untracked cache notifications
Date: Tue, 8 Dec 2015 18:15:09 +0100 [thread overview]
Message-ID: <1449594916-21167-2-git-send-email-chriscool@tuxfamily.org> (raw)
In-Reply-To: <1449594916-21167-1-git-send-email-chriscool@tuxfamily.org>
Doing:
cd /tmp
git --git-dir=/git/somewhere/else/.git update-index --untracked-cache
doesn't work how one would expect. It hardcodes "/tmp" as the directory
that "works" into the index, so if you use the working tree, you'll
never use the untracked cache.
With this patch "git update-index --untracked-cache" tells the user in
which directory tests are performed and in which working directory the
untracked cache is allowed.
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
builtin/update-index.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/builtin/update-index.c b/builtin/update-index.c
index 7431938..6f6b289 100644
--- a/builtin/update-index.c
+++ b/builtin/update-index.c
@@ -121,7 +121,7 @@ static int test_if_untracked_cache_is_supported(void)
if (!mkdtemp(mtime_dir.buf))
die_errno("Could not make temporary directory");
- fprintf(stderr, _("Testing "));
+ fprintf(stderr, _("Testing mtime in '%s' "), xgetcwd());
atexit(remove_test_directory);
xstat_mtime_dir(&st);
fill_stat_data(&base, &st);
@@ -1122,9 +1122,11 @@ int cmd_update_index(int argc, const char **argv, const char *prefix)
}
add_untracked_ident(the_index.untracked);
the_index.cache_changed |= UNTRACKED_CHANGED;
+ fprintf(stderr, _("Untracked cache enabled for '%s'\n"), get_git_work_tree());
} else if (!untracked_cache && the_index.untracked) {
the_index.untracked = NULL;
the_index.cache_changed |= UNTRACKED_CHANGED;
+ fprintf(stderr, _("Untracked cache disabled\n"));
}
if (active_cache_changed) {
--
2.6.3.478.g9f95483.dirty
next prev parent reply other threads:[~2015-12-08 17:15 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 17:15 [PATCH 0/8] Untracked cache improvements Christian Couder
2015-12-08 17:15 ` Christian Couder [this message]
2015-12-08 19:03 ` [PATCH 1/8] update-index: add untracked cache notifications Junio C Hamano
2015-12-11 8:51 ` Christian Couder
2015-12-08 17:15 ` [PATCH 2/8] update-index: use enum for untracked cache options Christian Couder
2015-12-08 19:11 ` Junio C Hamano
2015-12-10 10:37 ` Christian Couder
2015-12-10 18:46 ` Junio C Hamano
2015-12-11 9:10 ` Christian Couder
2015-12-11 17:44 ` Junio C Hamano
2015-12-12 9:25 ` Christian Couder
2015-12-08 17:15 ` [PATCH 3/8] update-index: add --test-untracked-cache Christian Couder
2015-12-08 17:15 ` [PATCH 4/8] update-index: move 'uc' var declaration Christian Couder
2015-12-08 17:15 ` [PATCH 5/8] dir: add add_untracked_cache() Christian Couder
2015-12-09 7:37 ` Torsten Bögershausen
2015-12-11 8:54 ` Christian Couder
2015-12-08 17:15 ` [PATCH 6/8] dir: add remove_untracked_cache() Christian Couder
2015-12-08 19:15 ` Junio C Hamano
2015-12-09 7:39 ` Torsten Bögershausen
2015-12-08 17:15 ` [PATCH 7/8] config: add core.untrackedCache Christian Couder
2015-12-08 19:28 ` Junio C Hamano
2015-12-08 22:43 ` Junio C Hamano
2015-12-14 12:18 ` Christian Couder
2015-12-14 19:44 ` Junio C Hamano
2015-12-14 21:30 ` Junio C Hamano
2015-12-15 9:34 ` Christian Couder
2015-12-15 9:49 ` Torsten Bögershausen
2015-12-15 16:42 ` Christian Couder
2015-12-15 10:02 ` Duy Nguyen
2015-12-15 16:35 ` Christian Couder
2015-12-15 13:04 ` Ævar Arnfjörð Bjarmason
2015-12-15 13:42 ` Christian Couder
2015-12-15 19:40 ` Junio C Hamano
2015-12-15 21:53 ` Ævar Arnfjörð Bjarmason
2015-12-15 23:03 ` Junio C Hamano
2015-12-16 1:10 ` Ævar Arnfjörð Bjarmason
2015-12-16 2:46 ` Jeff King
2015-12-16 5:20 ` Junio C Hamano
2015-12-16 6:05 ` Junio C Hamano
2015-12-17 7:44 ` Jeff King
2015-12-17 12:26 ` Duy Nguyen
[not found] ` <CAP8UFD0S_rWKjWiq_enkN+QVtvnq9fuwAxuuVTXTxu-F1mw4dg@mail.gmail.com>
2015-12-18 22:40 ` Fwd: " Christian Couder
2015-12-21 18:30 ` Junio C Hamano
2015-12-22 8:27 ` Duy Nguyen
2015-12-22 16:33 ` Junio C Hamano
2015-12-24 1:56 ` Junio C Hamano
2015-12-24 9:49 ` Duy Nguyen
2015-12-27 20:21 ` Junio C Hamano
2015-12-24 20:54 ` Christian Couder
[not found] ` <CAP8UFD0LAQG+gQ5EhYYLjo5=tpW3_ah6GV-mgRbgTjjgNmdorA@mail.gmail.com>
2015-12-18 22:38 ` Fwd: " Christian Couder
2015-12-17 12:36 ` Duy Nguyen
2015-12-18 23:24 ` Christian Couder
2015-12-09 13:19 ` Torsten Bögershausen
2015-12-08 17:15 ` [PATCH 8/8] t7063: add tests for core.untrackedCache Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449594916-21167-2-git-send-email-chriscool@tuxfamily.org \
--to=christian.couder@gmail.com \
--cc=avarab@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).