git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Philip Oakley <philipoakley@iee.org>
To: Git List <git@vger.kernel.org>,
	Pat Thoyts <patthoyts@users.sourceforge.net>
Cc: Alexey Astakhov <asstv7@gmail.com>, sender <philipoakley@iee.org>
Subject: [PATCH v1 0/4] Fix git-gui when recentrepo list has duplicates
Date: Mon, 14 Dec 2015 15:08:59 +0000	[thread overview]
Message-ID: <1450105743-2432-1-git-send-email-philipoakley@iee.org> (raw)
In-Reply-To: <3453668A49C94C2AA39911FC594AE151@PhilipOakley>

This is the patch series which follows from a user report of not being
able to start the git-gui when it contained duplicate entries.

The git gui design assumes that there will never be duplicate entries
in the recent repo list, and attempts to keep it that way.

For reasons unknown (other applications or tcl bugs?) there are cases
where the global .gitconfig does contain duplicate entries in the
gui.recentrepo config var. contrary to expectation.

The patch series fixes the root of the issue first, then patches the
logic for the two functional usages of _unset_recentrepo.

Finally, the displayable recentrepos list region is expanded to allow
extended recentrepo lists to at least be shown, before the git-gui
wrangles then back down to the allowed maxrecent size.

Philip Oakley (4):
  git-gui: remove duplicate entries from .gitconfig's gui.recentrepo
  git gui: cope with duplicates in _get_recentrepo
  git gui: de-dup selected repo from recentrepo history
  git gui: allow for a long recentrepo list

 git-gui/lib/choose_repository.tcl | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

-- 
2.5.2.windows.2

  reply	other threads:[~2015-12-14 15:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-13 12:59 git gui: fail on dual entries in recent repo list Philip Oakley
2015-12-14 15:08 ` Philip Oakley [this message]
2015-12-14 15:09   ` [PATCH v1 1/4] git-gui: remove duplicate entries from .gitconfig's gui.recentrepo Philip Oakley
2015-12-14 22:31     ` Eric Sunshine
2015-12-16 23:41       ` Philip Oakley
2015-12-17  7:45         ` Eric Sunshine
2015-12-14 15:09   ` [PATCH v1 2/4] git gui: cope with duplicates in _get_recentrepo Philip Oakley
2015-12-14 15:09   ` [PATCH v1 3/4] git gui: de-dup selected repo from recentrepo history Philip Oakley
2015-12-14 15:09   ` [PATCH v1 4/4] git gui: allow for a long recentrepo list Philip Oakley
2015-12-14 22:36     ` Eric Sunshine
2015-12-15  0:04       ` Philip Oakley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1450105743-2432-1-git-send-email-philipoakley@iee.org \
    --to=philipoakley@iee.org \
    --cc=asstv7@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=patthoyts@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).