From: "SZEDER Gábor" <szeder@ira.uka.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Jeff King" <peff@peff.net>,
git@vger.kernel.org, "SZEDER Gábor" <szeder@ira.uka.de>
Subject: [PATCH] credential-store: don't pass strerror to die_errno()
Date: Wed, 16 Dec 2015 12:22:55 +0100 [thread overview]
Message-ID: <1450264975-9760-1-git-send-email-szeder@ira.uka.de> (raw)
In-Reply-To: <1449138687-23675-1-git-send-email-szeder@ira.uka.de>
Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
---
v2 fixed this, but it fell on the floor, I suppose because of the
maintainer switch. Anyway, I should have noticed it while the patch
was still cooking, sorry.
credential-store.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/credential-store.c b/credential-store.c
index fc67d16c1088..54c4e0473737 100644
--- a/credential-store.c
+++ b/credential-store.c
@@ -64,8 +64,7 @@ static void rewrite_credential_file(const char *fn, struct credential *c,
print_line(extra);
parse_credential_file(fn, c, NULL, print_line);
if (commit_lock_file(&credential_lock) < 0)
- die_errno("unable to write credential store: %s",
- strerror(errno));
+ die_errno("unable to write credential store");
}
static void store_credential_file(const char *fn, struct credential *c)
--
2.7.0.rc0.37.g77d69b9
next prev parent reply other threads:[~2015-12-16 11:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 11:40 [PATCH] Make error message after failing commit_lock_file() less confusing SZEDER Gábor
2015-12-01 23:17 ` Jeff King
2015-12-02 2:19 ` Junio C Hamano
2015-12-02 4:28 ` Eric Sunshine
2015-12-03 10:30 ` SZEDER Gábor
2015-12-03 10:31 ` [PATCH v2] " SZEDER Gábor
2015-12-16 11:22 ` SZEDER Gábor [this message]
2015-12-16 18:20 ` [PATCH] credential-store: don't pass strerror to die_errno() Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450264975-9760-1-git-send-email-szeder@ira.uka.de \
--to=szeder@ira.uka.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).