git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Doug Kelly <dougk.ff7@gmail.com>
To: git@vger.kernel.org
Cc: peff@peff.net, sbeller@google.com, gitster@pobox.com,
	Doug Kelly <dougk.ff7@gmail.com>
Subject: [PATCH v3 0/3] prepare_packed_git(): find more garbage
Date: Fri, 18 Dec 2015 18:06:37 -0600	[thread overview]
Message-ID: <1450483600-64091-1-git-send-email-dougk.ff7@gmail.com> (raw)
In-Reply-To: <20151215232534.GA30998@sigill.intra.peff.net>

Corrects the issues found in review by Peff, including simplifying
the logic in report_helper().  bits_to_msg() would've been an alternate
solution to that change, however it'll get called by
real_report_garbage(), so there's no need to call it twice, especially
when the check we need within report_helper().

I think checking for seen_bits == 0 would be future-proofing should we
arrive at a file bit not otherwise match it (i.e. file.foo and
file.bar, but nothing else would cause seen_bits to be zero, but if
that's the case, we wouldn't have PACKDIR_FILE_IDX or
PACKDIR_FILE_PACK set, either, and the second half would also match.

Doug Kelly (3):
  prepare_packed_git(): find more garbage
  t5304: Add test for .bitmap garbage files
  gc: Clean garbage .bitmap files from pack dir

 builtin/count-objects.c | 16 ++++++----------
 builtin/gc.c            | 12 ++++++++++--
 cache.h                 |  4 +++-
 sha1_file.c             | 12 +++++++++---
 t/t5304-prune.sh        | 20 ++++++++++++++++++++
 5 files changed, 48 insertions(+), 16 deletions(-)

-- 
2.6.1

  reply	other threads:[~2015-12-19  0:07 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-14  0:10 [PATCH 0/3] Add cleanup for garbage .bitmap files Doug Kelly
2015-11-14  0:10 ` [PATCH 1/3] prepare_packed_git(): find more garbage Doug Kelly
2015-11-14  0:43   ` Stefan Beller
2015-11-14  0:46     ` Doug Kelly
2015-11-14  0:46       ` [PATCH 2/3] t5304: Add test for .bitmap garbage files Doug Kelly
2015-11-14  0:46       ` [PATCH 3/3] gc: Clean garbage .bitmap files from pack dir Doug Kelly
2015-12-15 23:23         ` Jeff King
2015-11-25 18:43       ` [PATCH 1/3] prepare_packed_git(): find more garbage Stefan Beller
2015-11-26  6:15         ` Doug Kelly
2015-12-15 23:09           ` Jeff King
2015-12-15 23:25             ` Jeff King
2015-12-19  0:06               ` Doug Kelly [this message]
2015-12-19  0:06                 ` Doug Kelly
2015-12-19  0:06                 ` [PATCH 2/3] t5304: Add test for .bitmap garbage files Doug Kelly
2015-12-19  0:06                 ` [PATCH 3/3] gc: Clean garbage .bitmap files from pack dir Doug Kelly
2015-12-19  2:01                   ` Jeff King
2015-12-19  2:02                 ` [PATCH v3 0/3] prepare_packed_git(): find more garbage Jeff King
2015-12-19  2:03                   ` Jeff King
2016-01-11 16:35                     ` Stefan Beller
2016-01-13 17:07                 ` [PATCH v4 0/4] gc: Clean garbage .bitmap files from pack dir Doug Kelly
2016-01-13 17:07                   ` [PATCH 1/4] prepare_packed_git(): find more garbage Doug Kelly
2016-01-13 17:07                   ` [PATCH 2/4] t5304: Add test for .bitmap garbage files Doug Kelly
2016-01-13 20:42                     ` Junio C Hamano
2016-01-13 17:07                   ` [PATCH 3/4] t5304: Ensure wanted files are not deleted Doug Kelly
2016-01-13 20:55                     ` Junio C Hamano
2016-01-18 16:54                       ` Doug Kelly
2016-01-19 18:36                         ` Junio C Hamano
2016-01-13 17:07                   ` [PATCH 4/4] gc: Clean garbage .bitmap files from pack dir Doug Kelly
2015-11-26  6:18         ` [PATCH 1/3] prepare_packed_git(): find more garbage Doug Kelly
2015-11-14  0:47     ` Doug Kelly
2015-11-14  0:10 ` [PATCH 2/3] t5304: Add test for .bitmap garbage files Doug Kelly
2015-11-14  0:47   ` Stefan Beller
2015-11-14  0:10 ` [PATCH 3/3] gc: Clean garbage .bitmap files from pack dir Doug Kelly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1450483600-64091-1-git-send-email-dougk.ff7@gmail.com \
    --to=dougk.ff7@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=sbeller@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).