From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 05/10] t/t5505-remote.sh: use the $( ... ) construct for command substitution Date: Wed, 23 Dec 2015 14:45:53 +0100 Message-ID: <1450878358-7422-6-git-send-email-gitter.spiros@gmail.com> References: <1450878358-7422-1-git-send-email-gitter.spiros@gmail.com> Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Wed Dec 23 14:46:45 2015 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aBjkb-0002dg-1N for gcvg-git-2@plane.gmane.org; Wed, 23 Dec 2015 14:46:45 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933859AbbLWNqi (ORCPT ); Wed, 23 Dec 2015 08:46:38 -0500 Received: from mail-pa0-f49.google.com ([209.85.220.49]:36619 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933808AbbLWNqV (ORCPT ); Wed, 23 Dec 2015 08:46:21 -0500 Received: by mail-pa0-f49.google.com with SMTP id q3so112890869pav.3 for ; Wed, 23 Dec 2015 05:46:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=VcrksGb/UyVSszY6s/8OpePHizevnM0MNOZMBzmREOQ=; b=kTiig3+YyIz/QRMMDfBNoypAja02ln9FqG/RvAxwk+WqALYvS9nEh7dvZNzXjpeTj6 JRP4h1Qqmsn2aOhsGnhZW7B/XxWm5+wD4OXQe2OIMBWK2NFtXYBRb8kgNqxw0x7LmpAt 2UH2TS3SJcGQOB9h7AH44kLVDYL2KJbgfmH1xhO3ueeYz/fCwc0oi0hVNA5ovMtlSRD0 mzjff27mAHfm5tskfw9azSld6xZFErkBs6mH4vSZkFUKnHbE2KcjTVcFKoxsoSgNh8kd 4czgPKkILLl0UIZB+tVHqM6dm0w9/yBvSW7mJZP6sJ5QKWSTz5rfHq/Sc7i/ewTH2f3c D4mw== X-Received: by 10.66.227.102 with SMTP id rz6mr43635529pac.4.1450878381563; Wed, 23 Dec 2015 05:46:21 -0800 (PST) Received: from ubuntu14.nephoscale.com ([67.207.195.141]) by smtp.gmail.com with ESMTPSA id p83sm48250443pfi.96.2015.12.23.05.46.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 23 Dec 2015 05:46:20 -0800 (PST) X-Mailer: git-send-email 2.3.3.GIT In-Reply-To: <1450878358-7422-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto --- t/t5505-remote.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t5505-remote.sh b/t/t5505-remote.sh index dfaf9d9..1a8e3b8 100755 --- a/t/t5505-remote.sh +++ b/t/t5505-remote.sh @@ -85,7 +85,7 @@ test_expect_success C_LOCALE_OUTPUT 'check remote-tracking' ' test_expect_success 'remote forces tracking branches' ' ( cd test && - case `git config remote.second.fetch` in + case $(git config remote.second.fetch) in +*) true ;; *) false ;; esac -- 2.3.3.GIT