From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 09/10] t/t5700-clone-reference.sh: use the $( ... ) construct for command substitution Date: Mon, 4 Jan 2016 10:10:50 +0100 Message-ID: <1451898651-16468-10-git-send-email-gitter.spiros@gmail.com> References: <1451898651-16468-1-git-send-email-gitter.spiros@gmail.com> Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Mon Jan 04 10:11:51 2016 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aG1B7-000551-Qf for gcvg-git-2@plane.gmane.org; Mon, 04 Jan 2016 10:11:50 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753237AbcADJLQ (ORCPT ); Mon, 4 Jan 2016 04:11:16 -0500 Received: from mail-pa0-f47.google.com ([209.85.220.47]:34634 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753230AbcADJLJ (ORCPT ); Mon, 4 Jan 2016 04:11:09 -0500 Received: by mail-pa0-f47.google.com with SMTP id uo6so174591743pac.1 for ; Mon, 04 Jan 2016 01:11:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=AvVVBX3oN/5REJHfhhyBbD1u8PkxZTMOVxRxWcfkFT8=; b=uXLExmrApOwLs/YTxvKlqRhStVBTkGo+CrfRE2Eg5G+NInIsIAt8iejLQ80Tbc/ORq 691TCkSRQqEY8ViGl3pOTyPhuePAInC9pJaWPqMNfRvuv9bjf4Uk9bxWh0WsXoz1M05z iUlqXA1AGL7w1QUUwZL1WKUPJ49O91Jt68Bxagt1ifUGV8UBP8qSm28b5R+iSlBG4X8z sBT/C7wRag95cQEZ4siEDtEERZXfLzId/69GO8WOTNGjr/41GvFmFNmJg+vDuszis4Dr Mp7Ggmiq7+Q8DKl5unml0ZzAEYeVOF48M8DMqfwwqeZ3aMVlxezXV+SdB/WYTyqnY3nW 9tPA== X-Received: by 10.66.222.101 with SMTP id ql5mr125649065pac.144.1451898668690; Mon, 04 Jan 2016 01:11:08 -0800 (PST) Received: from ubuntu14.nephoscale.com (static-67.207.195.141.nephosdns.com. [67.207.195.141]) by smtp.gmail.com with ESMTPSA id h10sm124416205pat.7.2016.01.04.01.11.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 04 Jan 2016 01:11:08 -0800 (PST) X-Mailer: git-send-email 2.3.3.GIT In-Reply-To: <1451898651-16468-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto --- t/t5700-clone-reference.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t5700-clone-reference.sh b/t/t5700-clone-reference.sh index dfa1bf7..4320082 100755 --- a/t/t5700-clone-reference.sh +++ b/t/t5700-clone-reference.sh @@ -6,7 +6,7 @@ test_description='test clone --reference' . ./test-lib.sh -base_dir=`pwd` +base_dir=$(pwd) U=$base_dir/UPLOAD_LOG -- 2.3.3.GIT