From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 10/10] t/t5710-info-alternate.sh: use the $( ... ) construct for command substitution Date: Mon, 4 Jan 2016 10:10:51 +0100 Message-ID: <1451898651-16468-11-git-send-email-gitter.spiros@gmail.com> References: <1451898651-16468-1-git-send-email-gitter.spiros@gmail.com> Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Mon Jan 04 10:11:34 2016 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aG1Aj-0004sO-RE for gcvg-git-2@plane.gmane.org; Mon, 04 Jan 2016 10:11:26 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753245AbcADJLT (ORCPT ); Mon, 4 Jan 2016 04:11:19 -0500 Received: from mail-pa0-f49.google.com ([209.85.220.49]:33491 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753231AbcADJLJ (ORCPT ); Mon, 4 Jan 2016 04:11:09 -0500 Received: by mail-pa0-f49.google.com with SMTP id cy9so194553541pac.0 for ; Mon, 04 Jan 2016 01:11:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=F5B/BIBUV3TjqL4NiFTSow3drdBRVkVr9dkYeROUARg=; b=SqTIhptk2NBRld3L7lqpn8Nk930A5TYF8zNej2ET5IbQm6o2DppT8sUAgqE9FkbCPA gk+lcc5uiqig6UIxDjINjvZ9dNs+CnJKBBNgX6yKU2pI6/qfH/4LZ+dyEZFiqtxB8c74 iJDl8GgYNRI3aIaJpRUPPRFu37uTy102Hr7aomdrfM8DLSav6voHW1Pd+1Ac2sPrGyrO ld1TEz10W3korz/uuyM/EleFb/wu4BANhW4Q4pZKksVoYD++T08fl8To50LFn/ZaRbqD /0XTRSZMaxQeLhUbHBBlIcUj5TwdavK81UwDW2XvQ+BmyzSoDDpGiNI34QvnN3EFbUlB tnFQ== X-Received: by 10.67.5.69 with SMTP id ck5mr124926850pad.125.1451898669368; Mon, 04 Jan 2016 01:11:09 -0800 (PST) Received: from ubuntu14.nephoscale.com (static-67.207.195.141.nephosdns.com. [67.207.195.141]) by smtp.gmail.com with ESMTPSA id h10sm124416205pat.7.2016.01.04.01.11.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 04 Jan 2016 01:11:08 -0800 (PST) X-Mailer: git-send-email 2.3.3.GIT In-Reply-To: <1451898651-16468-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto --- t/t5710-info-alternate.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t5710-info-alternate.sh b/t/t5710-info-alternate.sh index 5a6e49d..9cd2626 100755 --- a/t/t5710-info-alternate.sh +++ b/t/t5710-info-alternate.sh @@ -21,7 +21,7 @@ test_valid_repo() { test_line_count = 0 fsck.log } -base_dir=`pwd` +base_dir=$(pwd) test_expect_success 'preparing first repository' \ 'test_create_repo A && cd A && -- 2.3.3.GIT