From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 05/10] t/t5538-push-shallow.sh: use the $( ... ) construct for command substitution Date: Mon, 4 Jan 2016 10:10:46 +0100 Message-ID: <1451898651-16468-6-git-send-email-gitter.spiros@gmail.com> References: <1451898651-16468-1-git-send-email-gitter.spiros@gmail.com> Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Mon Jan 04 10:11:37 2016 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aG1Al-0004sO-Oc for gcvg-git-2@plane.gmane.org; Mon, 04 Jan 2016 10:11:28 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753042AbcADJLZ (ORCPT ); Mon, 4 Jan 2016 04:11:25 -0500 Received: from mail-pa0-f43.google.com ([209.85.220.43]:33460 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753225AbcADJLG (ORCPT ); Mon, 4 Jan 2016 04:11:06 -0500 Received: by mail-pa0-f43.google.com with SMTP id cy9so194552622pac.0 for ; Mon, 04 Jan 2016 01:11:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=UnSsQtAZVCMusrTEtGRdJF01OmS0fbLxgi7yqDiXfbM=; b=0xt3tT1ZlGx57zKEVJ8YZz7Xexir3O+xjvemvUrcbXxAZ7wos++hJFiDje0v3q+sSL s7Ox+PPMooFrj7ikZkt15Y6l/PSPX+cCnMIkpWLkTzBT0oT7GCh0heWE3ub3OGArkeA5 iVUA6ti9SExCiDBi3/IG78rRAQ+BS0eEaMbofMo2UN6p/u7IdkkfW/VNgsmHx3vP4NG1 ZKJ913LAwjU/QDXAxehUXQG5ERPJfA6HBB0Z7jhZJwvpW+yOs9ylTufWtFNCEATCk5cD 0wFj12xxJAMHB97UvNL2z7wImgBo5dBZGVVju62pvwrKdhdxcGjLVX7dpTVTnEX4st76 Xjmg== X-Received: by 10.66.155.8 with SMTP id vs8mr125527166pab.18.1451898665722; Mon, 04 Jan 2016 01:11:05 -0800 (PST) Received: from ubuntu14.nephoscale.com (static-67.207.195.141.nephosdns.com. [67.207.195.141]) by smtp.gmail.com with ESMTPSA id h10sm124416205pat.7.2016.01.04.01.11.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 04 Jan 2016 01:11:05 -0800 (PST) X-Mailer: git-send-email 2.3.3.GIT In-Reply-To: <1451898651-16468-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto --- t/t5538-push-shallow.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t5538-push-shallow.sh b/t/t5538-push-shallow.sh index ceee95b..ecbf84d 100755 --- a/t/t5538-push-shallow.sh +++ b/t/t5538-push-shallow.sh @@ -104,7 +104,7 @@ EOF ' test_expect_success 'push from full to shallow' ' - ! git --git-dir=shallow2/.git cat-file blob `echo 1|git hash-object --stdin` && + ! git --git-dir=shallow2/.git cat-file blob $(echo 1|git hash-object --stdin) && commit 1 && git push shallow2/.git +master:refs/remotes/top/master && ( @@ -117,7 +117,7 @@ test_expect_success 'push from full to shallow' ' 3 EOF test_cmp expect actual && - git cat-file blob `echo 1|git hash-object --stdin` >/dev/null + git cat-file blob $(echo 1|git hash-object --stdin) >/dev/null ) ' test_done -- 2.3.3.GIT