From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 08/10] t/t5601-clone.sh: use the $( ... ) construct for command substitution Date: Mon, 4 Jan 2016 10:10:49 +0100 Message-ID: <1451898651-16468-9-git-send-email-gitter.spiros@gmail.com> References: <1451898651-16468-1-git-send-email-gitter.spiros@gmail.com> Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Mon Jan 04 10:11:49 2016 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aG1B7-000551-8K for gcvg-git-2@plane.gmane.org; Mon, 04 Jan 2016 10:11:49 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753241AbcADJLR (ORCPT ); Mon, 4 Jan 2016 04:11:17 -0500 Received: from mail-pa0-f54.google.com ([209.85.220.54]:34628 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753149AbcADJLI (ORCPT ); Mon, 4 Jan 2016 04:11:08 -0500 Received: by mail-pa0-f54.google.com with SMTP id uo6so174591572pac.1 for ; Mon, 04 Jan 2016 01:11:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=QojjpSFbMkMxeZEnfYL4dVVWJRc1DIIVcPQPZ7LzJXw=; b=mkhFJAaJL8neWnKm0proJ2eOq9UWsA6GcNp94oYtoHAcx/Srpck3KDs+6BoNcZ3CuP FNUaWy8z5JqyX/xNrcu38oNNw1MMTIOgTNKwos/UA6WJQJPvZ4HUJUjYS9+XNVb20LiU QmdnBSR0lQn9r0aJIfIrFacq7ItnRpXp5P7etx9h/OprbyYsWM3QWLnePQxhoFuES9Qq COLG+eOaBq32dKniSvL3jSCv1S+6DYtOOuhdxYWP0ly/nNahaFbOezAvUAOaG2wCkaH1 LHwuN2faFJ5iFQxBLm83qY8bCDLq0Jb7mtUb0FewbSc8n2BHHNSXAAFxo+mbQ9jZIWiD DcHQ== X-Received: by 10.66.65.203 with SMTP id z11mr125652336pas.152.1451898668035; Mon, 04 Jan 2016 01:11:08 -0800 (PST) Received: from ubuntu14.nephoscale.com (static-67.207.195.141.nephosdns.com. [67.207.195.141]) by smtp.gmail.com with ESMTPSA id h10sm124416205pat.7.2016.01.04.01.11.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 04 Jan 2016 01:11:07 -0800 (PST) X-Mailer: git-send-email 2.3.3.GIT In-Reply-To: <1451898651-16468-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto --- t/t5601-clone.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t5601-clone.sh b/t/t5601-clone.sh index 9b34f3c..61dc4ce 100755 --- a/t/t5601-clone.sh +++ b/t/t5601-clone.sh @@ -221,7 +221,7 @@ test_expect_success 'clone separate gitdir' ' ' test_expect_success 'clone separate gitdir: output' ' - echo "gitdir: `pwd`/realgitdir" >expected && + echo "gitdir: $(pwd)/realgitdir" >expected && test_cmp expected dst/.git ' -- 2.3.3.GIT