From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 05/10] t/t6032-merge-large-rename.sh: use the $( ... ) construct for command substitution Date: Thu, 7 Jan 2016 14:51:45 +0100 Message-ID: <1452174710-28188-6-git-send-email-gitter.spiros@gmail.com> References: <1452174710-28188-1-git-send-email-gitter.spiros@gmail.com> Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Thu Jan 07 14:52:23 2016 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aHAzF-00024f-VR for gcvg-git-2@plane.gmane.org; Thu, 07 Jan 2016 14:52:22 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752738AbcAGNwQ (ORCPT ); Thu, 7 Jan 2016 08:52:16 -0500 Received: from mail-pa0-f53.google.com ([209.85.220.53]:35329 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752693AbcAGNwA (ORCPT ); Thu, 7 Jan 2016 08:52:00 -0500 Received: by mail-pa0-f53.google.com with SMTP id qh10so9247932pab.2 for ; Thu, 07 Jan 2016 05:52:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=PjUntUhCtzMxilxF7Vanq0/DvuzS2EGmafjPLNFuHtg=; b=l1cTwgqeIhH1WvhW9bAeD5m8Rxi+fZO84rTMubVztOTQ9GlA+I9K0UkLcJgPQeDiUo cPk+W1cRLw66KYpKf0mZHvjFkF+fPaZSYoPD4hQw01SlA+bokS25RwnLfK5F0VSrYNRu U34TS2KN3ObkeqqFdRZBZHK46zbuNIyb86GtGjamvWLGQQE9qJN9A2Rb0YJTGSArp92X YhHsQoWwpdT9C4olJ6COOnM0kS1VhPAiP01L6eAatS2+RqM7M81LRevUaU1ZIwG7SrrZ Iwb/QtvAEAmowR2R20Fgsd7oEdtFy2WQOU74of8JDXCXK8mwUHZo6Ye7qiVe/lg4yCtG Qa6A== X-Received: by 10.66.142.232 with SMTP id rz8mr151665928pab.74.1452174720002; Thu, 07 Jan 2016 05:52:00 -0800 (PST) Received: from ubuntu14.nephoscale.com (static-67.207.195.141.nephosdns.com. [67.207.195.141]) by smtp.gmail.com with ESMTPSA id kk5sm140627824pab.16.2016.01.07.05.51.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 07 Jan 2016 05:51:59 -0800 (PST) X-Mailer: git-send-email 2.3.3.GIT In-Reply-To: <1452174710-28188-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto --- t/t6032-merge-large-rename.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t6032-merge-large-rename.sh b/t/t6032-merge-large-rename.sh index 0f79268..8077738 100755 --- a/t/t6032-merge-large-rename.sh +++ b/t/t6032-merge-large-rename.sh @@ -20,7 +20,7 @@ test_expect_success 'setup (initial)' ' make_text() { echo $1: $2 - for i in `count 20`; do + for i in $(count 20); do echo $1: $i done echo $1: $3 -- 2.3.3.GIT