From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 06/10] t/t6132-pathspec-exclude.sh: use the $( ... ) construct for command substitution Date: Thu, 7 Jan 2016 14:51:46 +0100 Message-ID: <1452174710-28188-7-git-send-email-gitter.spiros@gmail.com> References: <1452174710-28188-1-git-send-email-gitter.spiros@gmail.com> Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Thu Jan 07 14:52:15 2016 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aHAz6-00021A-CJ for gcvg-git-2@plane.gmane.org; Thu, 07 Jan 2016 14:52:12 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752729AbcAGNwF (ORCPT ); Thu, 7 Jan 2016 08:52:05 -0500 Received: from mail-pa0-f54.google.com ([209.85.220.54]:33097 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752709AbcAGNwB (ORCPT ); Thu, 7 Jan 2016 08:52:01 -0500 Received: by mail-pa0-f54.google.com with SMTP id cy9so259466211pac.0 for ; Thu, 07 Jan 2016 05:52:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5aK5ydwNaAURrknYAHSCUAk9r7zbeRTuyKdpuGzL5H8=; b=NuUTEtGUEfmrGSahkXV1QWYM0UpLSpf/lgM+zS9Xzx/EThDz1acaGQiVNolgIXGBoV EL67SIEwrn1lJ8PqwCQi/AfQi4lgoS7Z84mcLThoZ8xpZ9EoYdSdxFDiGUf+3JY+Hrgj Jc7QgiwgcN+9VANacdo/ihfBUk5xmdL1XpuDrs5yGTRmFO+Aa1FTyuPb6D2HHuo+UM11 GoktJ4s787TEc7cGR9IZzosDe7PuEYsj6FP83+H2XvQ6o1EYjpCJeKBB5UYN6gvhFSzf w47Ccd3ds0im54NsAlrCs6mwdNxo8TU5DXotAX/FJkAOESiGchyVvTCKJCxUv61B3r/9 Z1GA== X-Received: by 10.66.117.199 with SMTP id kg7mr151576601pab.105.1452174720712; Thu, 07 Jan 2016 05:52:00 -0800 (PST) Received: from ubuntu14.nephoscale.com (static-67.207.195.141.nephosdns.com. [67.207.195.141]) by smtp.gmail.com with ESMTPSA id kk5sm140627824pab.16.2016.01.07.05.52.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 07 Jan 2016 05:52:00 -0800 (PST) X-Mailer: git-send-email 2.3.3.GIT In-Reply-To: <1452174710-28188-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto --- t/t6132-pathspec-exclude.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t6132-pathspec-exclude.sh b/t/t6132-pathspec-exclude.sh index e1e1b1f..d51595c 100755 --- a/t/t6132-pathspec-exclude.sh +++ b/t/t6132-pathspec-exclude.sh @@ -7,7 +7,7 @@ test_description='test case exclude pathspec' test_expect_success 'setup' ' for p in file sub/file sub/sub/file sub/file2 sub/sub/sub/file sub2/file; do if echo $p | grep /; then - mkdir -p `dirname $p` + mkdir -p $(dirname $p) fi && : >$p && git add $p && -- 2.3.3.GIT