From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 03/10] t/t7408-submodule-reference.sh: use the $( ... ) construct for command substitution Date: Fri, 8 Jan 2016 12:06:21 +0100 Message-ID: <1452251188-12939-4-git-send-email-gitter.spiros@gmail.com> References: <1452251188-12939-1-git-send-email-gitter.spiros@gmail.com> Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Fri Jan 08 12:07:13 2016 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aHUss-0003EA-37 for gcvg-git-2@plane.gmane.org; Fri, 08 Jan 2016 12:07:06 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754762AbcAHLHA (ORCPT ); Fri, 8 Jan 2016 06:07:00 -0500 Received: from mail-pf0-f196.google.com ([209.85.192.196]:36431 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754548AbcAHLGg (ORCPT ); Fri, 8 Jan 2016 06:06:36 -0500 Received: by mail-pf0-f196.google.com with SMTP id n128so618270pfn.3 for ; Fri, 08 Jan 2016 03:06:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=afO0fjhhkKQ64LAxFvWIxzMiSRIJ85n7KrZIR4Ly5v4=; b=TWRJAg5AB9hv7Ywqc0ovKA6j3JB+AdQa8CyBKV7q4c+13lD3xga2CVSjiXaXUHXOep Rdy2Q+tVabaRNNLQNjKKUxzAuK3Xx4q2CYwFAPdh6QYa9BiOlYWq0e3MS9i8KcFQ7jN7 S750gz/ydLuNzNkJLryI9d+mkyVqoY5ZI1A+Thf5ibeH+VEIBj0LfB49c0SFn4eL1Q0p 2K2kSJYqnYmefxFG5WQ3vThS4WIqa5b4eOdAPQHPlwVaRNkzS92ix+MvccGErL0InX5a N87CzozY2WVCSbW7qCPwO09jmilw+48j9nhJzN7oJIr+ox/2/VwLHAV7jwzur6+QxeEn w2pg== X-Received: by 10.98.75.143 with SMTP id d15mr3409285pfj.96.1452251196192; Fri, 08 Jan 2016 03:06:36 -0800 (PST) Received: from ubuntu14.nephoscale.com (static-67.207.195.141.nephosdns.com. [67.207.195.141]) by smtp.gmail.com with ESMTPSA id fi16sm93143771pac.12.2016.01.08.03.06.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 08 Jan 2016 03:06:35 -0800 (PST) X-Mailer: git-send-email 2.3.3.GIT In-Reply-To: <1452251188-12939-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto --- t/t7408-submodule-reference.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t7408-submodule-reference.sh b/t/t7408-submodule-reference.sh index b770b2f..eaea19b 100755 --- a/t/t7408-submodule-reference.sh +++ b/t/t7408-submodule-reference.sh @@ -6,7 +6,7 @@ test_description='test clone --reference' . ./test-lib.sh -base_dir=`pwd` +base_dir=$(pwd) U=$base_dir/UPLOAD_LOG -- 2.3.3.GIT