From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 08/10] t9110-git-svn-use-svm-props.sh: use the $( ... ) construct for command substitution Date: Tue, 12 Jan 2016 10:45:16 +0000 Message-ID: <1452595518-38149-9-git-send-email-gitter.spiros@gmail.com> References: <1452595518-38149-1-git-send-email-gitter.spiros@gmail.com> Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Tue Jan 12 11:46:28 2016 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aIwT5-00080c-TG for gcvg-git-2@plane.gmane.org; Tue, 12 Jan 2016 11:46:28 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934848AbcALKpm (ORCPT ); Tue, 12 Jan 2016 05:45:42 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:35454 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934409AbcALKpb (ORCPT ); Tue, 12 Jan 2016 05:45:31 -0500 Received: by mail-wm0-f66.google.com with SMTP id f206so30626015wmf.2 for ; Tue, 12 Jan 2016 02:45:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=v/K2qoUiFH1syTRVF0an9B/7wGH328c2bn2ikaeBerI=; b=WpXJSEx0RAUAl4iNWPjtirsgqZNeUmVM8jMl2lJhJrapZIMjy/2ob6b8SngQjEgy8a Bw60YohsTkGsjn9ym3B8kfXd/ujPS9jb5VRojVnkROZI1px8oF8HDNqiEBz8FDSVjhEO MOqVBonbKWFPhkZKYmhgt/thLeAxmppkslfHbekE/R99in7fCDjr9r8w6xAlbdimzWaa hNRLFjDl7DfWh9G3xXv9+GfeRxvO5qXuJbF/IR45YFBt/kF52XdruT7VWxWreBRXHscR +iYdupRfPAKbGrWH+oXjS1TnQwky5cIvQyq9HFCKz6pCmQgOp6DIr2OLnuG5w3FKIL0K YAlg== X-Received: by 10.28.230.92 with SMTP id d89mr13742395wmh.12.1452595530063; Tue, 12 Jan 2016 02:45:30 -0800 (PST) Received: from ubuntu2pinto.pd5x2phgis1evm2itoce0l41ib.ax.internal.cloudapp.net ([40.113.119.92]) by smtp.gmail.com with ESMTPSA id gb9sm96320537wjb.26.2016.01.12.02.45.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 12 Jan 2016 02:45:29 -0800 (PST) X-Mailer: git-send-email 2.7.0.rc0.20.g4b9ab0e.dirty In-Reply-To: <1452595518-38149-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto --- t/t9110-git-svn-use-svm-props.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t9110-git-svn-use-svm-props.sh b/t/t9110-git-svn-use-svm-props.sh index a06e4c5..29fbdfd 100755 --- a/t/t9110-git-svn-use-svm-props.sh +++ b/t/t9110-git-svn-use-svm-props.sh @@ -51,7 +51,7 @@ test_expect_success 'verify metadata for /dir' " test_expect_success 'find commit based on SVN revision number' " git svn find-rev r12 | - grep `git rev-parse HEAD` + grep $(git rev-parse HEAD) " test_expect_success 'empty rebase' " -- 2.5.0