From: Elia Pinto <gitter.spiros@gmail.com>
To: git@vger.kernel.org
Cc: Elia Pinto <gitter.spiros@gmail.com>
Subject: [PATCH 11/12] t9501-gitweb-standalone-http-status.sh: use the $( ... ) construct for command substitution
Date: Tue, 12 Jan 2016 11:49:37 +0000 [thread overview]
Message-ID: <1452599378-47882-12-git-send-email-gitter.spiros@gmail.com> (raw)
In-Reply-To: <1452599378-47882-1-git-send-email-gitter.spiros@gmail.com>
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.
The backquoted form is the traditional method for command
substitution, and is supported by POSIX. However, all but the
simplest uses become complicated quickly. In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.
The patch was generated by:
for _f in $(find . -name "*.sh")
do
perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}"
done
and then carefully proof-read.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
t/t9501-gitweb-standalone-http-status.sh | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/t/t9501-gitweb-standalone-http-status.sh b/t/t9501-gitweb-standalone-http-status.sh
index d3a5bac..2a0ffed 100755
--- a/t/t9501-gitweb-standalone-http-status.sh
+++ b/t/t9501-gitweb-standalone-http-status.sh
@@ -100,14 +100,14 @@ test_expect_success 'snapshots: bad tree-ish id (tagged object)' '
echo object > tag-object &&
git add tag-object &&
test_tick && git commit -m "Object to be tagged" &&
- git tag tagged-object `git hash-object tag-object` &&
+ git tag tagged-object $(git hash-object tag-object) &&
gitweb_run "p=.git;a=snapshot;h=tagged-object;sf=tgz" &&
grep "400 - Object is not a tree-ish" gitweb.output
'
test_debug 'cat gitweb.output'
test_expect_success 'snapshots: good object id' '
- ID=`git rev-parse --verify HEAD` &&
+ ID=$(git rev-parse --verify HEAD) &&
gitweb_run "p=.git;a=snapshot;h=$ID;sf=tgz" &&
grep "Status: 200 OK" gitweb.output
'
@@ -173,7 +173,7 @@ test_expect_success DATE_PARSER 'modification: snapshot if-modified-since (unmod
test_debug 'cat gitweb.headers'
test_expect_success DATE_PARSER 'modification: tree snapshot' '
- ID=`git rev-parse --verify HEAD^{tree}` &&
+ ID=$(git rev-parse --verify HEAD^{tree}) &&
HTTP_IF_MODIFIED_SINCE="Wed, 6 Apr 2005 22:14:13 +0000" &&
export HTTP_IF_MODIFIED_SINCE &&
test_when_finished "unset HTTP_IF_MODIFIED_SINCE" &&
--
2.5.0
next prev parent reply other threads:[~2016-01-12 11:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 11:49 [PATCH 00/12] use the $( ... ) construct for command substitution Elia Pinto
2016-01-12 11:49 ` [PATCH 01/12] t9119-git-svn-info.sh: " Elia Pinto
2016-01-12 11:49 ` [PATCH 02/12] t9129-git-svn-i18n-commitencoding.sh: " Elia Pinto
2016-01-12 11:49 ` [PATCH 03/12] t9130-git-svn-authors-file.sh: " Elia Pinto
2016-01-12 11:49 ` [PATCH 04/12] t9132-git-svn-broken-symlink.sh: " Elia Pinto
2016-01-12 11:49 ` [PATCH 05/12] t9137-git-svn-dcommit-clobber-series.sh: " Elia Pinto
2016-01-12 11:49 ` [PATCH 06/12] t9138-git-svn-authors-prog.sh: " Elia Pinto
2016-01-12 11:49 ` [PATCH 07/12] t9145-git-svn-master-branch.sh: " Elia Pinto
2016-01-12 11:49 ` [PATCH 08/12] t9150-svk-mergetickets.sh: " Elia Pinto
2016-01-12 19:59 ` Junio C Hamano
2016-01-12 11:49 ` [PATCH 09/12] t9300-fast-import.sh: " Elia Pinto
2016-01-12 11:49 ` [PATCH 10/12] t9350-fast-export.sh: " Elia Pinto
2016-01-12 11:49 ` Elia Pinto [this message]
2016-01-12 11:49 ` [PATCH 12/12] t9901-git-web--browse.sh: " Elia Pinto
2016-01-12 19:51 ` [PATCH 00/12] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452599378-47882-12-git-send-email-gitter.spiros@gmail.com \
--to=gitter.spiros@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).