From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 12/12] t9901-git-web--browse.sh: use the $( ... ) construct for command substitution Date: Tue, 12 Jan 2016 11:49:38 +0000 Message-ID: <1452599378-47882-13-git-send-email-gitter.spiros@gmail.com> References: <1452599378-47882-1-git-send-email-gitter.spiros@gmail.com> Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Tue Jan 12 12:50:04 2016 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aIxSd-0007nM-Jm for gcvg-git-2@plane.gmane.org; Tue, 12 Jan 2016 12:50:03 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964936AbcALLty (ORCPT ); Tue, 12 Jan 2016 06:49:54 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:35814 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964920AbcALLtv (ORCPT ); Tue, 12 Jan 2016 06:49:51 -0500 Received: by mail-wm0-f66.google.com with SMTP id f206so30919234wmf.2 for ; Tue, 12 Jan 2016 03:49:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ZON+mFlUGu03py+K1kWe7RiYQMcWkouFy2uBeJbJWx4=; b=SpN0PiGjKdQu5cOL5EMMQdOSSFjzrV+7QGiFlcJ868pp/3keWcM9VP5w4D3I2kc+ej mtn3iBXeXktvcxK1Utj054nObuJYqkSODKVnNGwADIwsk2tV4DwKPWWaL3GWOLwfnC0g Rd7Zu/6v7VqGP6uAasUoNFzISvyv/SVCXJOdMlHXiIkDNb+fsWN+YuK7qCwg6KWPwjnD gnHt+niYC2vh2qjP9/panWDk5X7k4EbbeLohDVzkBZzhwlkGnUdxZCyLM0i1w5h82TNr PqlhoI+DahUwJbwXUC2JBak8jI3A32pPsbD+eHpgt1JYUIYscc0vGZiU/RexNBoANYAo wg0A== X-Received: by 10.28.88.8 with SMTP id m8mr20215704wmb.73.1452599390361; Tue, 12 Jan 2016 03:49:50 -0800 (PST) Received: from ubuntu2pinto.pd5x2phgis1evm2itoce0l41ib.ax.internal.cloudapp.net ([40.113.119.92]) by smtp.gmail.com with ESMTPSA id k130sm3506702wmg.6.2016.01.12.03.49.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 12 Jan 2016 03:49:49 -0800 (PST) X-Mailer: git-send-email 2.7.0.rc0.20.g4b9ab0e.dirty In-Reply-To: <1452599378-47882-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto --- t/t9901-git-web--browse.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t9901-git-web--browse.sh b/t/t9901-git-web--browse.sh index b0a6bad..de7152f 100755 --- a/t/t9901-git-web--browse.sh +++ b/t/t9901-git-web--browse.sh @@ -43,7 +43,7 @@ test_expect_success \ echo fake: "$@" EOF chmod +x "fake browser" && - git config browser.w3m.path "`pwd`/fake browser" && + git config browser.w3m.path "$(pwd)/fake browser" && test_web_browse w3m http://example.com/foo ' -- 2.5.0