From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 04/12] t9132-git-svn-broken-symlink.sh: use the $( ... ) construct for command substitution Date: Tue, 12 Jan 2016 11:49:30 +0000 Message-ID: <1452599378-47882-5-git-send-email-gitter.spiros@gmail.com> References: <1452599378-47882-1-git-send-email-gitter.spiros@gmail.com> Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Tue Jan 12 12:50:32 2016 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aIxT2-00082o-N4 for gcvg-git-2@plane.gmane.org; Tue, 12 Jan 2016 12:50:29 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760204AbcALLuR (ORCPT ); Tue, 12 Jan 2016 06:50:17 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:32882 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934368AbcALLtp (ORCPT ); Tue, 12 Jan 2016 06:49:45 -0500 Received: by mail-wm0-f67.google.com with SMTP id u188so30860798wmu.0 for ; Tue, 12 Jan 2016 03:49:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=vuR6n6sqCmBUFENlbnErn+t/j4dZUybZvEZ+yskO6bU=; b=IUED3xRYe1JZJrJVZQkqAix0i5J6W1+WhGeo/T0twAQMeLHjTq8+uxGqPgDCAy/BmD ix+4dewNgcKDzCop1COtAdUcuT0V9MzFf+yruG46LsnJC4kSZzsh5MbNQgqhmKGxYvg0 OJUI2rNlNKSkxASiE0jwT+pQHmTDrPHB7KwIV4RIh6z6LesHjD8ZNvnZfhpbsg4k+7un eRjSpcE4qozUqrQGjhGq/ThyTs3j4pEnYVJSZ+U03kHdFK4MAEJUSNNsyhtj6nCgegW0 MxntA5RGr+QBkn15BwwlE66RVUmD4Fe8TCZELq3bPRpVqK0HCTe40cp9q/pi+dpAdvuq wXbA== X-Received: by 10.195.13.129 with SMTP id ey1mr98209416wjd.132.1452599384871; Tue, 12 Jan 2016 03:49:44 -0800 (PST) Received: from ubuntu2pinto.pd5x2phgis1evm2itoce0l41ib.ax.internal.cloudapp.net ([40.113.119.92]) by smtp.gmail.com with ESMTPSA id k130sm3506702wmg.6.2016.01.12.03.49.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 12 Jan 2016 03:49:44 -0800 (PST) X-Mailer: git-send-email 2.7.0.rc0.20.g4b9ab0e.dirty In-Reply-To: <1452599378-47882-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto --- t/t9132-git-svn-broken-symlink.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t9132-git-svn-broken-symlink.sh b/t/t9132-git-svn-broken-symlink.sh index 6c4c90b..aeceffa 100755 --- a/t/t9132-git-svn-broken-symlink.sh +++ b/t/t9132-git-svn-broken-symlink.sh @@ -87,7 +87,7 @@ test_expect_success 'clone using git svn' 'git svn clone -r1 "$svnrepo" x' test_expect_success SYMLINKS '"bar" is a symlink that points to "asdf"' ' test -L x/bar && - (cd x && test xasdf = x"`git cat-file blob HEAD:bar`") + (cd x && test xasdf = x"$(git cat-file blob HEAD:bar)") ' test_expect_success 'get "bar" => symlink fix from svn' ' @@ -96,7 +96,7 @@ test_expect_success 'get "bar" => symlink fix from svn' ' test_expect_success SYMLINKS '"bar" remains a proper symlink' ' test -L x/bar && - (cd x && test xdoink = x"`git cat-file blob HEAD:bar`") + (cd x && test xdoink = x"$(git cat-file blob HEAD:bar)") ' test_done -- 2.5.0