From: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
To: git@vger.kernel.org
Cc: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: [PATCH v2 0/6] Kill and replace update_linked_gitdir()
Date: Mon, 18 Jan 2016 18:21:28 +0700 [thread overview]
Message-ID: <1453116094-4987-1-git-send-email-pclouds@gmail.com> (raw)
There are a couple of problems with this function:
- premature design
- create "gitdir" file outside multi-worktree context
- update the file's content with relative path, with breaks "worktree list"
The first three patches kill it, as a result. They are relatively safe.
The last three re-implement it in a new form, "worktree refresh",
inspired by "update-index --refresh". For now the user can use this
command to correct some internal data after moving a worktree. In
future, we might do automatic refresh like we do with the index.
The last three try out new design, so it will probably take more time
to graduate than the first three, which may end up in the next release
as worktree bug fix.
Eric Sunshine (1):
worktree.txt: how to fix up after moving a worktree
Nguyễn Thái Ngọc Duy (5):
worktree.c: fix indentation
worktree: stop supporting moving worktrees manually
abspath.c: add and use real_path_dup()
setup.c: record the location of .git file
worktree: new command to fix up worktree's info after moving
Documentation/git-worktree.txt | 21 ++++++++++++++++-----
abspath.c | 5 +++++
builtin/clone.c | 2 +-
builtin/init-db.c | 6 +++---
builtin/worktree.c | 18 ++++++++++++++++++
cache.h | 2 ++
setup.c | 26 +++++++++++---------------
t/t1501-worktree.sh | 9 +++++++++
worktree.c | 8 ++++----
9 files changed, 69 insertions(+), 28 deletions(-)
--
2.7.0.96.g5373197
next reply other threads:[~2016-01-18 11:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 11:21 Nguyễn Thái Ngọc Duy [this message]
2016-01-18 11:21 ` [PATCH v2 1/6] worktree.c: fix indentation Nguyễn Thái Ngọc Duy
2016-01-18 11:21 ` [PATCH v2 2/6] worktree: stop supporting moving worktrees manually Nguyễn Thái Ngọc Duy
2016-01-18 18:24 ` Eric Sunshine
2016-01-18 11:21 ` [PATCH v2 3/6] worktree.txt: how to fix up after moving a worktree Nguyễn Thái Ngọc Duy
2016-01-18 18:30 ` Eric Sunshine
2016-01-19 5:20 ` Duy Nguyen
2016-01-18 11:21 ` [PATCH v2 4/6] abspath.c: add and use real_path_dup() Nguyễn Thái Ngọc Duy
2016-01-18 11:21 ` [PATCH v2 5/6] setup.c: record the location of .git file Nguyễn Thái Ngọc Duy
2016-01-18 11:21 ` [PATCH v2 6/6] worktree: new command to fix up worktree's info after moving Nguyễn Thái Ngọc Duy
2016-01-18 13:07 ` Philip Oakley
2016-01-19 18:25 ` Junio C Hamano
2016-01-22 8:35 ` [PATCH v3 0/2] Kill and replace update_linked_gitdir() Nguyễn Thái Ngọc Duy
2016-01-22 8:35 ` [PATCH v3 1/2] worktree.c: fix indentation Nguyễn Thái Ngọc Duy
2016-01-22 8:35 ` [PATCH v3 2/2] worktree: stop supporting moving worktrees manually Nguyễn Thái Ngọc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453116094-4987-1-git-send-email-pclouds@gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).