From: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
To: git@vger.kernel.org
Cc: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: [PATCH 20/20] worktree: move repo, convert main worktree
Date: Wed, 3 Feb 2016 16:35:50 +0700 [thread overview]
Message-ID: <1454492150-10628-21-git-send-email-pclouds@gmail.com> (raw)
In-Reply-To: <1454492150-10628-1-git-send-email-pclouds@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
builtin/worktree.c | 87 ++++++++++++++++++++++++++++++++++++++++++------
t/t2028-worktree-move.sh | 36 ++++++++++++++++++++
2 files changed, 112 insertions(+), 11 deletions(-)
diff --git a/builtin/worktree.c b/builtin/worktree.c
index 80a8b80..3f69369 100644
--- a/builtin/worktree.c
+++ b/builtin/worktree.c
@@ -479,10 +479,11 @@ static int list(int ac, const char **av, const char *prefix)
static int move_gitdir(int ac, const char **av, const char *prefix)
{
- struct string_list paths = STRING_LIST_INIT_NODUP;
+ struct string_list per_worktree = STRING_LIST_INIT_DUP;
struct strbuf dst = STRBUF_INIT;
struct strbuf src = STRBUF_INIT;
struct worktree **worktrees, *mwt = NULL;
+ struct worktree tmp;
int i, ret = 0;
if (ac != 1)
@@ -492,29 +493,93 @@ static int move_gitdir(int ac, const char **av, const char *prefix)
strbuf_addstr(&dst, real_path(prefix_filename(prefix, strlen(prefix), av[0])));
worktrees = get_worktrees();
- for (i = 0; worktrees[i]; i++) {
- if (is_main_worktree(worktrees[i]))
+ for (i = 0; worktrees[i]; i++)
+ if (is_main_worktree(worktrees[i])) {
mwt = worktrees[i];
- string_list_append(&paths,
- get_worktree_git_dir(worktrees[i]));
- }
+ break;
+ }
+
+ if (mwt) {
+ struct strbuf sb = STRBUF_INIT;
+
+ strbuf_addstr(&sb, real_path(get_git_common_dir()));
+ if (ends_with(sb.buf, "/.git"))
+ sb.len -= strlen("/.git");
+ else
+ die(_("unrecognized repository directory layout: %s"),
+ sb.buf);
+ sb.buf[sb.len] = '\0';
+ prepare_new_worktree(sb.buf, &tmp, 0);
+ strbuf_release(&sb);
+
+ if (collect_per_worktree_git_paths(&per_worktree))
+ die(_("failed to collect per-worktree paths"));
+
+ for (i = 0; !ret && i < per_worktree.nr; i++) {
+ const char *path = per_worktree.items[i].string;
+
+ if (safe_create_leading_directories_const(
+ git_common_path("worktrees/%s/%s", tmp.id, path)) ||
+ copy_file(git_common_path("worktrees/%s/%s", tmp.id, path),
+ git_common_path("%s", path),
+ 0777))
+ die_errno(_("failed to copy '%s' to '%s'"),
+ git_common_path("%s", path),
+ git_common_path("worktrees/%s/%s", tmp.id, path));
+ }
- if (mwt)
- die(_("converting main worktree is not supported"));
+ mwt->id = xstrdup(tmp.id);
+ cleanup_new_worktree(&tmp);
+ }
ret = copy_dir_recursively(src.buf, dst.buf);
if (ret)
die(_("failed to copy '%s' to '%s'"), src.buf, dst.buf);
- for (i = 0; paths.nr; i++)
- if (update_worktree_gitfile(paths.items[i].string, dst.buf,
+ if (mwt) {
+ struct strbuf sb = STRBUF_INIT;
+ int len;
+
+ new_worktree_complete();
+
+ strbuf_addbuf(&sb, &dst);
+ if (sb.buf[sb.len - 1] != '/')
+ strbuf_addch(&sb, '/');
+ len = sb.len;
+ for (i = 0; !ret && i < per_worktree.nr; i++) {
+ const char *path = per_worktree.items[i].string;
+
+ strbuf_addstr(&sb, path);
+ unlink_or_warn(sb.buf);
+ strbuf_setlen(&sb, len);
+ }
+ string_list_clear(&per_worktree, 0);
+
+ strbuf_addstr(&sb, "HEAD");
+ write_file(sb.buf, sha1_to_hex(null_sha1));
+
+ strbuf_reset(&sb);
+ strbuf_addf(&sb, "%s.old", src.buf);
+ if (rename(src.buf, sb.buf))
+ die_errno(_("failed to move '%s' to '%s'"), src.buf, sb.buf);
+ /* XXX: rename back on die() */
+ strbuf_swap(&sb, &src);
+ strbuf_release(&sb);
+ }
+
+ for (i = 0; worktrees[i]; i++) {
+ struct strbuf sb = STRBUF_INIT;
+
+ strbuf_addf(&sb, "%s/.git", worktrees[i]->path);
+ if (update_worktree_gitfile(sb.buf, dst.buf,
worktrees[i]->id))
ret = -1;
+ strbuf_release(&sb);
+ }
if (!ret)
ret = remove_dir_recursively(&src, 0);
- string_list_clear(&paths, 0);
return ret;
}
diff --git a/t/t2028-worktree-move.sh b/t/t2028-worktree-move.sh
index e8f6f0c..5e9e1d4 100755
--- a/t/t2028-worktree-move.sh
+++ b/t/t2028-worktree-move.sh
@@ -38,4 +38,40 @@ test_expect_success 'move main worktree' '
test_must_fail git worktree move . def
'
+test_expect_success 'move repository and convert main worktree' '
+ git worktree move --repository repo &&
+ test_path_is_file .git &&
+ test_path_is_dir repo &&
+ git fsck &&
+ git worktree list --porcelain | grep "^worktree" >actual &&
+ cat <<-EOF >expected &&
+ worktree $TRASH_DIRECTORY
+ worktree $TRASH_DIRECTORY/destination
+ EOF
+ test_cmp expected actual &&
+ git -C destination log --format=%s >actual2 &&
+ echo init >expected2 &&
+ test_cmp expected2 actual2 &&
+ git log --format=%s >actual3 &&
+ test_cmp expected2 actual3
+'
+
+test_expect_success 'move repository alone' '
+ git worktree move --repository repo2 &&
+ test_path_is_file .git &&
+ test_path_is_dir repo2 &&
+ git fsck &&
+ git worktree list --porcelain | grep "^worktree" >actual &&
+ cat <<-EOF >expected &&
+ worktree $TRASH_DIRECTORY
+ worktree $TRASH_DIRECTORY/destination
+ EOF
+ test_cmp expected actual &&
+ git -C destination log --format=%s >actual2 &&
+ echo init >expected2 &&
+ test_cmp expected2 actual2 &&
+ git log --format=%s >actual3 &&
+ test_cmp expected2 actual3
+'
+
test_done
--
2.7.0.377.g4cd97dd
next prev parent reply other threads:[~2016-02-03 9:37 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 9:35 [PATCH 00/20] "git worktree move" preview Nguyễn Thái Ngọc Duy
2016-02-03 9:35 ` [PATCH 01/20] usage.c: move format processing out of die_errno() Nguyễn Thái Ngọc Duy
2016-02-03 9:35 ` [PATCH 02/20] usage.c: add sys_error() that prints strerror() automatically Nguyễn Thái Ngọc Duy
2016-02-03 9:35 ` [PATCH 03/20] path.c: add git_common_path() and strbuf_git_common_path() Nguyễn Thái Ngọc Duy
2016-02-03 9:35 ` [PATCH 04/20] path.c: add is_git_path_shared() Nguyễn Thái Ngọc Duy
2016-02-03 9:35 ` [PATCH 05/20] copy.c: add copy_dir_recursively() Nguyễn Thái Ngọc Duy
2016-02-03 9:35 ` [PATCH 06/20] worktree.c: use is_dot_or_dotdot() Nguyễn Thái Ngọc Duy
2016-02-03 9:35 ` [PATCH 07/20] worktree.c: store "id" instead of "git_dir" Nguyễn Thái Ngọc Duy
2016-02-03 9:35 ` [PATCH 08/20] worktree.c: add clear_worktree() Nguyễn Thái Ngọc Duy
2016-02-03 9:35 ` [PATCH 09/20] worktree.c: add find_worktree_by_path() Nguyễn Thái Ngọc Duy
2016-02-03 9:35 ` [PATCH 10/20] worktree.c: add is_main_worktree() Nguyễn Thái Ngọc Duy
2016-02-03 9:35 ` [PATCH 11/20] worktree.c: recognize no main worktree Nguyễn Thái Ngọc Duy
2016-02-03 9:35 ` [PATCH 12/20] worktree.c: add update_worktree_location() Nguyễn Thái Ngọc Duy
2016-02-03 9:35 ` [PATCH 13/20] worktree.c: add update_worktree_gitfile() Nguyễn Thái Ngọc Duy
2016-02-03 9:35 ` [PATCH 14/20] worktree.c: add collect_per_worktree_git_paths() Nguyễn Thái Ngọc Duy
2016-02-03 9:35 ` [PATCH 15/20] worktree: avoid 0{40}, too many zeroes, hard to read Nguyễn Thái Ngọc Duy
2016-02-03 9:35 ` [PATCH 16/20] worktree: simplify prefixing paths Nguyễn Thái Ngọc Duy
2016-02-03 9:35 ` [PATCH 17/20] worktree: add "move" commmand Nguyễn Thái Ngọc Duy
2016-02-03 9:35 ` [PATCH 18/20] worktree: refactor add_worktree() Nguyễn Thái Ngọc Duy
2016-02-03 9:35 ` [PATCH 19/20] worktree: move repo, simple case Nguyễn Thái Ngọc Duy
2016-02-03 9:35 ` Nguyễn Thái Ngọc Duy [this message]
2016-02-16 13:29 ` [PATCH v2 00/26] worktree lock, move, remove and unlock Nguyễn Thái Ngọc Duy
2016-02-16 13:29 ` [PATCH v2 01/26] usage.c: move format processing out of die_errno() Nguyễn Thái Ngọc Duy
2016-02-16 13:29 ` [PATCH v2 02/26] usage.c: add sys_error() that prints strerror() automatically Nguyễn Thái Ngọc Duy
2016-02-16 13:29 ` [PATCH v2 03/26] copy.c: import copy_file() from busybox Nguyễn Thái Ngọc Duy
2016-02-16 13:29 ` [PATCH v2 04/26] copy.c: delete unused code in copy_file() Nguyễn Thái Ngọc Duy
2016-02-16 13:29 ` [PATCH v2 05/26] copy.c: convert bb_(p)error_msg to (sys_)error Nguyễn Thái Ngọc Duy
2016-02-16 13:29 ` [PATCH v2 06/26] copy.c: style fix Nguyễn Thái Ngọc Duy
2016-02-16 13:29 ` [PATCH v2 07/26] copy.c: convert copy_file() to copy_dir_recursively() Nguyễn Thái Ngọc Duy
2016-02-16 13:29 ` [PATCH v2 08/26] completion: support git-worktree Nguyễn Thái Ngọc Duy
2016-02-16 13:29 ` [PATCH v2 09/26] git-worktree.txt: keep subcommand listing in alphabetical order Nguyễn Thái Ngọc Duy
2016-02-16 13:29 ` [PATCH v2 10/26] wrapper.c: allow to create an empty file with write_file() Nguyễn Thái Ngọc Duy
2016-02-17 22:29 ` Junio C Hamano
2016-02-18 0:49 ` Duy Nguyen
2016-02-16 13:29 ` [PATCH v2 11/26] path.c: add git_common_path() and strbuf_git_common_path() Nguyễn Thái Ngọc Duy
2016-02-16 13:29 ` [PATCH v2 12/26] worktree.c: use is_dot_or_dotdot() Nguyễn Thái Ngọc Duy
2016-02-16 13:29 ` [PATCH v2 13/26] worktree.c: store "id" instead of "git_dir" Nguyễn Thái Ngọc Duy
2016-02-16 13:29 ` [PATCH v2 14/26] worktree.c: add clear_worktree() Nguyễn Thái Ngọc Duy
2016-02-16 13:29 ` [PATCH v2 15/26] worktree.c: add find_worktree_by_path() Nguyễn Thái Ngọc Duy
2016-02-16 13:29 ` [PATCH v2 16/26] worktree.c: add is_main_worktree() Nguyễn Thái Ngọc Duy
2016-02-16 13:29 ` [PATCH v2 17/26] worktree.c: add validate_worktree() Nguyễn Thái Ngọc Duy
2016-02-16 13:29 ` [PATCH v2 18/26] worktree.c: add update_worktree_location() Nguyễn Thái Ngọc Duy
2016-02-16 13:29 ` [PATCH v2 19/26] worktree.c: add is_worktree_locked() Nguyễn Thái Ngọc Duy
2016-02-16 13:29 ` [PATCH v2 20/26] worktree: avoid 0{40}, too many zeroes, hard to read Nguyễn Thái Ngọc Duy
2016-02-16 13:29 ` [PATCH v2 21/26] worktree: simplify prefixing paths Nguyễn Thái Ngọc Duy
2016-02-16 13:29 ` [PATCH v2 22/26] worktree: add "lock" command Nguyễn Thái Ngọc Duy
2016-02-16 13:29 ` [PATCH v2 23/26] worktree: add "unlock" command Nguyễn Thái Ngọc Duy
2016-02-16 13:29 ` [PATCH v2 24/26] worktree: add "move" commmand Nguyễn Thái Ngọc Duy
2016-02-16 13:29 ` [PATCH v2 25/26] worktree move: accept destination as directory Nguyễn Thái Ngọc Duy
2016-02-16 13:29 ` [PATCH v2 26/26] worktree: add "remove" command Nguyễn Thái Ngọc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454492150-10628-21-git-send-email-pclouds@gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).