From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?Nguy=E1=BB=85n=20Th=C3=A1i=20Ng=E1=BB=8Dc=20Duy?= Subject: [PATCH 7/8] index-pack: --append-pack implies --strict Date: Fri, 5 Feb 2016 15:57:56 +0700 Message-ID: <1454662677-15137-8-git-send-email-pclouds@gmail.com> References: <1454662677-15137-1-git-send-email-pclouds@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: =?UTF-8?q?Nguy=E1=BB=85n=20Th=C3=A1i=20Ng=E1=BB=8Dc=20Duy?= To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Fri Feb 05 09:58:57 2016 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aRcEA-0007l1-1X for gcvg-git-2@plane.gmane.org; Fri, 05 Feb 2016 09:58:54 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751961AbcBEI6u convert rfc822-to-quoted-printable (ORCPT ); Fri, 5 Feb 2016 03:58:50 -0500 Received: from mail-pf0-f169.google.com ([209.85.192.169]:34565 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751237AbcBEI6t (ORCPT ); Fri, 5 Feb 2016 03:58:49 -0500 Received: by mail-pf0-f169.google.com with SMTP id o185so65526331pfb.1 for ; Fri, 05 Feb 2016 00:58:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=m3FUikOb6kTLruwawaVAE0gHEx/4mmULZJ3XnN7j/H4=; b=IEUhJ/oKtjH4/LpRJ+HPmWY6R+wf9dc5fQMe/DTBgIxE4HDtuLEzReyNRmoszgC4e3 Ui140mZyhcIw7e4PtiV5AieVXyMSIjfZHTTTVOo+oyLfN9UsnR+SaivwRp7mlnO0T3yO o+xD59qfGdS9Lhi0Zzl56b3bCb8HMNck/VDl4gaoHvBB9XV54XCAQIEHxh75CM74N0UD AFBQwFlUYsXfrSRWk8WJmsInSIEJ1sRzrhVmIxblLGepxPPhe5VKLti5yHuJS5jFCk2v IfW7AOeMCW19aUDBETrpS8Q/bCzSA3YBg3uh5DfEy32UsOhcm11CRwyTq654UcBCwn60 UW8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=m3FUikOb6kTLruwawaVAE0gHEx/4mmULZJ3XnN7j/H4=; b=lGR7xykk1bOQVQZfinqFSn8XHw3w028BE/7EAPBtZFHRxwBzzvIB0UijU8YOzKEqAG /OpbPps1dbFkVBEaMbkc0wScWXMY1xSS6+22gIILu9ruS5a+1qOVTN8pSKdM2QNzljT/ q54Prgxlm55ohaS32sxelg1cxhkBgrD6NQku4xVIBqjg8aVJvWCZUqsBZyg+mGU1j/HZ NHSdQwh5dmyBz7ulEWLjbUvfoWx6/L7wqu66Agk6fijs1UdBVGcblIf97zQcvpzmnAbb emZVLJyNj3FwWagXPpsSG60KP6QEZfXg6xvvu2NhBKU/nA0BwHOH4y2w6GUkxzQI9giI 2ZaA== X-Gm-Message-State: AG10YOTZQQ96iLIC8a5Q9JfxBLHgFmYE4JuufY7XNJx/NPWIeQHNNbgz5XGnqVw4EurkJQ== X-Received: by 10.98.10.203 with SMTP id 72mr18334436pfk.87.1454662728721; Fri, 05 Feb 2016 00:58:48 -0800 (PST) Received: from lanh ([115.76.228.161]) by smtp.gmail.com with ESMTPSA id ud8sm15760735pac.11.2016.02.05.00.58.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Feb 2016 00:58:46 -0800 (PST) Received: by lanh (sSMTP sendmail emulation); Fri, 05 Feb 2016 15:59:02 +0700 X-Mailer: git-send-email 2.7.0.377.g4cd97dd In-Reply-To: <1454662677-15137-1-git-send-email-pclouds@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: A frankenstein pack, generated by multiple pack-objects runs, certainly has higher risk of broken, especially when the server side could be some other implementation than pack-objects. Be safe and strict. Signed-off-by: Nguy=E1=BB=85n Th=C3=A1i Ng=E1=BB=8Dc Duy --- builtin/index-pack.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/builtin/index-pack.c b/builtin/index-pack.c index f099ac2..cc60aee 100644 --- a/builtin/index-pack.c +++ b/builtin/index-pack.c @@ -1736,6 +1736,8 @@ int cmd_index_pack(int argc, const char **argv, c= onst char *prefix) if (*c || opts.off32_limit & 0x80000000) die(_("bad %s"), arg); } else if (skip_prefix(arg, "--append-pack=3D", &arg)) { + strict =3D 1; + do_fsck_object =3D 1; curr_pack =3D open_pack_for_append(arg); } else usage(index_pack_usage); --=20 2.7.0.377.g4cd97dd