From: Matt McCutchen <matt@mattmccutchen.net>
To: Junio C Hamano <gitster@pobox.com>, Duy Nguyen <pclouds@gmail.com>
Cc: git <git@vger.kernel.org>
Subject: Re: update_linked_gitdir writes relative path to .git/worktrees/<id>/gitdir
Date: Sun, 07 Feb 2016 20:04:38 -0500 [thread overview]
Message-ID: <1454893478.2511.5.camel@mattmccutchen.net> (raw)
In-Reply-To: <xmqqlh6w9isp.fsf@gitster.mtv.corp.google.com>
On Sun, 2016-02-07 at 15:56 -0800, Junio C Hamano wrote:
> Matt McCutchen <matt@mattmccutchen.net> writes:
>
> > I noticed that when update_linked_gitdir chooses to update
> > .git/worktrees/<id>/gitdir, the path it writes is relative, at
> > least
> > under some circumstances. This contradicts the gitrepository-
> > layout
> > man page, which says:
>
> Duy, is it safe to say that the fix has already been cooking in
> 'next' as nd/do-not-move-worktree-manually topic,
Yes, looks like that topic removes the buggy functionality.
> it is very much
> appreciated when reporting bugs people check if a presumed fix is
> already cooking in 'next', try it to verify if it really fixes their
> problem, and send in a "OK fix is good" / "No that does not fix my
> case"?
Sorry to waste your time. This wasn't documented where I looked,
namely the "Bug Reporting" section on http://git-scm.com/community .
Here's a straw-man proposed update to that page:
https://github.com/mattmccutchen/git-scm.com/compare/master...bug-reporting-next
If you like it, I will submit it as a pull request. I can propose a
similar update to the "REPORTING BUGS" section of the git(1) man page
if you like.
Matt
next prev parent reply other threads:[~2016-02-08 1:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-06 20:12 update_linked_gitdir writes relative path to .git/worktrees/<id>/gitdir Matt McCutchen
2016-02-07 23:56 ` Junio C Hamano
2016-02-08 1:04 ` Matt McCutchen [this message]
2016-02-08 4:56 ` Duy Nguyen
2016-02-08 13:56 ` Jeff King
2016-02-08 22:16 ` Junio C Hamano
2016-02-09 20:05 ` Matt McCutchen
2016-02-09 21:02 ` Junio C Hamano
2016-02-09 20:30 ` Making the "Note from the maintainer" information discoverable Matt McCutchen
2016-02-09 0:34 ` [PATCH] git.txt: encourage bug reporters to test recent versions Matt McCutchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454893478.2511.5.camel@mattmccutchen.net \
--to=matt@mattmccutchen.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).