From: Thomas Gummerer <t.gummerer@gmail.com>
To: git@vger.kernel.org
Cc: Johannes.Schindelin@gmx.de, gitster@pobox.com,
Thomas Gummerer <t.gummerer@gmail.com>
Subject: [PATCH 1/4] remote: use skip_prefix
Date: Mon, 15 Feb 2016 18:42:27 +0100 [thread overview]
Message-ID: <1455558150-30267-2-git-send-email-t.gummerer@gmail.com> (raw)
In-Reply-To: <1455558150-30267-1-git-send-email-t.gummerer@gmail.com>
95b567c7 ("use skip_prefix to avoid repeating strings") transformed
calls using starts_with() and then skipping the length of the prefix to
skip_prefix() calls. In remote.c there are a few calls like:
if (starts_with(foo, "bar"))
foo += 3
These calls weren't touched by the commit mentioned above, but can
benefit from the same treatment to avoid magic numbers.
Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com>
---
remote.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/remote.c b/remote.c
index 02e698a..4b5b576 100644
--- a/remote.c
+++ b/remote.c
@@ -321,8 +321,7 @@ static int handle_config(const char *key, const char *value, void *cb)
const char *subkey;
struct remote *remote;
struct branch *branch;
- if (starts_with(key, "branch.")) {
- name = key + 7;
+ if (skip_prefix(key, "branch.", &name)) {
subkey = strrchr(name, '.');
if (!subkey)
return 0;
@@ -338,9 +337,8 @@ static int handle_config(const char *key, const char *value, void *cb)
}
return 0;
}
- if (starts_with(key, "url.")) {
+ if (skip_prefix(key, "url.", &name)) {
struct rewrite *rewrite;
- name = key + 4;
subkey = strrchr(name, '.');
if (!subkey)
return 0;
@@ -357,9 +355,8 @@ static int handle_config(const char *key, const char *value, void *cb)
}
}
- if (!starts_with(key, "remote."))
+ if (!skip_prefix(key, "remote.", &name))
return 0;
- name = key + 7;
/* Handle remote.* variables */
if (!strcmp(name, "pushdefault"))
--
2.7.1.410.g6faf27b
next prev parent reply other threads:[~2016-02-15 17:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 17:42 [PATCH 0/4] git remote improvements Thomas Gummerer
2016-02-15 17:42 ` Thomas Gummerer [this message]
2016-02-15 18:18 ` [PATCH 1/4] remote: use skip_prefix Jeff King
2016-02-15 18:35 ` Eric Sunshine
2016-02-15 18:36 ` Jeff King
2016-02-15 20:37 ` Thomas Gummerer
2016-02-15 17:42 ` [PATCH 2/4] remote: simplify remote_is_configured() Thomas Gummerer
2016-02-15 18:21 ` Jeff King
2016-02-15 20:38 ` Thomas Gummerer
2016-02-15 21:37 ` Junio C Hamano
2016-02-15 17:42 ` [PATCH 3/4] remote: actually check if remote exits Thomas Gummerer
2016-02-15 18:23 ` Jeff King
2016-02-15 17:42 ` [PATCH 4/4] remote: use remote_is_configured() for add and rename Thomas Gummerer
2016-02-15 18:33 ` Jeff King
2016-02-15 20:43 ` Thomas Gummerer
2016-02-17 13:54 ` Johannes Schindelin
2016-02-17 14:24 ` Thomas Gummerer
2016-02-17 16:20 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455558150-30267-2-git-send-email-t.gummerer@gmail.com \
--to=t.gummerer@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).