From mboxrd@z Thu Jan 1 00:00:00 1970 From: Karthik Nayak Subject: [PATCH v5 10/12] ref-filter: introduce remote_ref_atom_parser() Date: Wed, 17 Feb 2016 00:30:13 +0530 Message-ID: <1455649215-23260-11-git-send-email-Karthik.188@gmail.com> References: <1455649215-23260-1-git-send-email-Karthik.188@gmail.com> Cc: gitster@pobox.com, sunshine@sunshineco.com, Karthik Nayak To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Tue Feb 16 20:00:26 2016 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aVkrE-00006h-6y for gcvg-git-2@plane.gmane.org; Tue, 16 Feb 2016 20:00:20 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933234AbcBPTAM (ORCPT ); Tue, 16 Feb 2016 14:00:12 -0500 Received: from mail-pf0-f171.google.com ([209.85.192.171]:35867 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933217AbcBPTAK (ORCPT ); Tue, 16 Feb 2016 14:00:10 -0500 Received: by mail-pf0-f171.google.com with SMTP id e127so109864122pfe.3 for ; Tue, 16 Feb 2016 11:00:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=uJFH+Fl/3mNlJ8pmZzsUHkIpO4RdpoU/Gl2kaqAh1ts=; b=bFmZu/E6lXkUspsdr3pHLMw5zLteJ30F/ICkRGiz2e5YuUGoQw4yMxuCvumeZ002H2 3ZwdDDSAml7AtL1z6rGm1vjcHBrGOFqmSD386BwgfNZvK6LxcaXk7E9VItuoixsD4cSx 8GYp+vj/pBDJhGYqiD/pMN4z3HqrUpU2xe8ylwinSMXUVuCxKZvWwJZh20ywjXeny2Mg sRO8munNXusUqRz5KOd6S6BWj1Ndv4zik7Ukh6d36Uy6o4qD8IiEcXEjRM7bZkGWJQMI oN/M4yegosWdYvTmTIksrt/twY5MOxhfezFS1SRpzC5WDXxFy209WB3Bgj8r5QST+4nr P1hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=uJFH+Fl/3mNlJ8pmZzsUHkIpO4RdpoU/Gl2kaqAh1ts=; b=UBp+ne+yQNlXdPW/IczyPObCan9Q1r/V4/4/ocWVNB8JSBYbrvkM8HDty0eQXR7b4c PEPalP3keVjaCfLne87EaNvsyudoEgYzaA8o+KDtjavAPUUtNo5d4MiCqVEXIdYf5AQx 6oQGQSoozqR5EbCJw5pT3djO++tokkh2UDR9ZWzBdTl+2IgaFZtqMiLPTAY0nN+W1waK 1QePuYES4C4SWhhXbmA3ZgX5fwRA47QHjdQd/O4qBpEnfZdqUkTURptPnzmJtxLPeH7L x5cPcIheYtlYyy3mG/bgc1qwMPUPPTgC6Rfb2OgDdOmRC35yTfhE+9UCpn94LEbb76KQ S/Jw== X-Gm-Message-State: AG10YOSpG+0M1LIwFyRWXDPHRzGzFrjdqLM0sKSuVbeJWvCJ4FUI81LkLifoHmwXinZt6A== X-Received: by 10.98.15.135 with SMTP id 7mr32898282pfp.142.1455649209832; Tue, 16 Feb 2016 11:00:09 -0800 (PST) Received: from ashley.localdomain ([106.51.133.38]) by smtp.gmail.com with ESMTPSA id 27sm47469677pfh.48.2016.02.16.11.00.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 16 Feb 2016 11:00:09 -0800 (PST) X-Google-Original-From: Karthik Nayak X-Mailer: git-send-email 2.7.1 In-Reply-To: <1455649215-23260-1-git-send-email-Karthik.188@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Introduce remote_ref_atom_parser() which will parse the '%(upstream)' and '%(push)' atoms and store information into the 'used_atom' structure based on the modifiers used along with the corresponding atom. Helped-by: Ramsay Jones Helped-by: Eric Sunshine Signed-off-by: Karthik Nayak --- ref-filter.c | 103 +++++++++++++++++++++++++++++++++++------------------------ 1 file changed, 61 insertions(+), 42 deletions(-) diff --git a/ref-filter.c b/ref-filter.c index 13a8280..8005e45 100644 --- a/ref-filter.c +++ b/ref-filter.c @@ -37,6 +37,8 @@ static struct used_atom { union { char color[COLOR_MAXLEN]; struct align align; + enum { RR_NORMAL, RR_SHORTEN, RR_TRACK, RR_TRACKSHORT } + remote_ref; } u; } *used_atom; static int used_atom_cnt, need_tagged, need_symref; @@ -50,6 +52,20 @@ static void color_atom_parser(struct used_atom *atom, const char *color_value) die(_("unrecognized color: %%(color:%s)"), color_value); } +static void remote_ref_atom_parser(struct used_atom *atom, const char *arg) +{ + if (!arg) + atom->u.remote_ref = RR_NORMAL; + else if (!strcmp(arg, "short")) + atom->u.remote_ref = RR_SHORTEN; + else if (!strcmp(arg, "track")) + atom->u.remote_ref = RR_TRACK; + else if (!strcmp(arg, "trackshort")) + atom->u.remote_ref = RR_TRACKSHORT; + else + die(_("unrecognized format: %%(%s)"), atom->name); +} + static align_type parse_align_position(const char *s) { if (!strcmp(s, "right")) @@ -132,8 +148,8 @@ static struct { { "subject" }, { "body" }, { "contents" }, - { "upstream" }, - { "push" }, + { "upstream", FIELD_STR, remote_ref_atom_parser }, + { "push", FIELD_STR, remote_ref_atom_parser }, { "symref" }, { "flag" }, { "HEAD" }, @@ -840,6 +856,43 @@ static const char *strip_ref_components(const char *refname, const char *nr_arg) return start; } +static void fill_remote_ref_details(struct used_atom *atom, const char *refname, + struct branch *branch, const char **s) +{ + int num_ours, num_theirs; + if (atom->u.remote_ref == RR_SHORTEN) + *s = shorten_unambiguous_ref(refname, warn_ambiguous_refs); + else if (atom->u.remote_ref == RR_TRACK) { + if (stat_tracking_info(branch, &num_ours, + &num_theirs, NULL)) + return; + + if (!num_ours && !num_theirs) + *s = ""; + else if (!num_ours) + *s = xstrfmt("[behind %d]", num_theirs); + else if (!num_theirs) + *s = xstrfmt("[ahead %d]", num_ours); + else + *s = xstrfmt("[ahead %d, behind %d]", + num_ours, num_theirs); + } else if (atom->u.remote_ref == RR_TRACKSHORT) { + if (stat_tracking_info(branch, &num_ours, + &num_theirs, NULL)) + return; + + if (!num_ours && !num_theirs) + *s = "="; + else if (!num_ours) + *s = "<"; + else if (!num_theirs) + *s = ">"; + else + *s = "<>"; + } else /* RR_NORMAL */ + *s = refname; +} + /* * Parse the object referred by ref, and grab needed value. */ @@ -891,8 +944,9 @@ static void populate_value(struct ref_array_item *ref) branch = branch_get(branch_name); refname = branch_get_upstream(branch, NULL); - if (!refname) - continue; + if (refname) + fill_remote_ref_details(atom, refname, branch, &v->s); + continue; } else if (starts_with(name, "push")) { const char *branch_name; if (!skip_prefix(ref->refname, "refs/heads/", @@ -903,6 +957,8 @@ static void populate_value(struct ref_array_item *ref) refname = branch_get_push(branch, NULL); if (!refname) continue; + fill_remote_ref_details(atom, refname, branch, &v->s); + continue; } else if (starts_with(name, "color:")) { v->s = atom->u.color; continue; @@ -944,7 +1000,6 @@ static void populate_value(struct ref_array_item *ref) formatp = strchr(name, ':'); if (formatp) { - int num_ours, num_theirs; const char *arg; formatp++; @@ -953,43 +1008,7 @@ static void populate_value(struct ref_array_item *ref) warn_ambiguous_refs); else if (skip_prefix(formatp, "strip=", &arg)) refname = strip_ref_components(refname, arg); - else if (!strcmp(formatp, "track") && - (starts_with(name, "upstream") || - starts_with(name, "push"))) { - - if (stat_tracking_info(branch, &num_ours, - &num_theirs, NULL)) - continue; - - if (!num_ours && !num_theirs) - v->s = ""; - else if (!num_ours) - v->s = xstrfmt("[behind %d]", num_theirs); - else if (!num_theirs) - v->s = xstrfmt("[ahead %d]", num_ours); - else - v->s = xstrfmt("[ahead %d, behind %d]", - num_ours, num_theirs); - continue; - } else if (!strcmp(formatp, "trackshort") && - (starts_with(name, "upstream") || - starts_with(name, "push"))) { - assert(branch); - - if (stat_tracking_info(branch, &num_ours, - &num_theirs, NULL)) - continue; - - if (!num_ours && !num_theirs) - v->s = "="; - else if (!num_ours) - v->s = "<"; - else if (!num_theirs) - v->s = ">"; - else - v->s = "<>"; - continue; - } else + else die("unknown %.*s format %s", (int)(formatp - name), name, formatp); } -- 2.7.1