git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: larsxschneider@gmail.com
To: git@vger.kernel.org
Cc: peff@peff.net, ramsay@ramsayjones.plus.com, gitster@pobox.com,
	Lars Schneider <larsxschneider@gmail.com>
Subject: [PATCH v5 0/3] config: add '--sources' option to print the source of a config value
Date: Wed, 17 Feb 2016 09:57:45 +0100	[thread overview]
Message-ID: <1455699468-45443-1-git-send-email-larsxschneider@gmail.com> (raw)

From: Lars Schneider <larsxschneider@gmail.com>

diff to v4:
* improve wording of "exit code" cleanup commit message (Thanks Peff)
* remove t1300 "--show-origin" test teardown (Thanks Peff)
* fix no parameter function prototype (Thanks Ramsay)
* use doublequotes instead of tabs to test quoted paths (Thanks Junio)

I though a while about Ramsay's suggestion to restore the old error messages
for config reads via stdin. Since reading the config via stdin is not that
common I don't think the increased complexity is worth the effort. Unless
Ramsay or someone else feels strongly about it, I would like to proceed and
keep the new error messages

Thanks for the review,
Lars


Lars Schneider (3):
  t: do not hide Git's exit code in tests using 'nul_to_q'
  config: add 'type' to config_source struct that identifies config type
  config: add '--show-origin' option to print the origin of a config
    value

 Documentation/git-config.txt |  15 ++--
 builtin/config.c             |  33 +++++++++
 cache.h                      |   6 +-
 config.c                     |  36 +++++++---
 submodule-config.c           |   4 +-
 t/t1300-repo-config.sh       | 161 ++++++++++++++++++++++++++++++++++++++++++-
 t/t1308-config-set.sh        |   4 +-
 t/t7008-grep-binary.sh       |   3 +-
 8 files changed, 236 insertions(+), 26 deletions(-)

--
2.5.1

             reply	other threads:[~2016-02-17  8:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-17  8:57 larsxschneider [this message]
2016-02-17  8:57 ` [PATCH v5 1/3] t: do not hide Git's exit code in tests using 'nul_to_q' larsxschneider
2016-02-17  8:57 ` [PATCH v5 2/3] config: add 'type' to config_source struct that identifies config type larsxschneider
2016-02-17 18:59   ` Junio C Hamano
2016-02-17 21:31     ` Junio C Hamano
2016-02-18  8:44       ` Lars Schneider
2016-02-17  8:57 ` [PATCH v5 3/3] config: add '--show-origin' option to print the origin of a config value larsxschneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1455699468-45443-1-git-send-email-larsxschneider@gmail.com \
    --to=larsxschneider@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).