git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: git@vger.kernel.org
Cc: Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>,
	ps@pks.im, Eric Sunshine <sunshine@sunshineco.com>,
	Stefan Beller <sbeller@google.com>,
	Lars Schneider <larsxschneider@gmail.com>,
	Michael Blume <blume.mike@gmail.com>
Subject: [PATCH v6 04/15] branch: die on config error when editing branch description
Date: Mon, 22 Feb 2016 12:23:25 +0100	[thread overview]
Message-ID: <1456140216-24169-5-git-send-email-ps@pks.im> (raw)
In-Reply-To: <1456140216-24169-1-git-send-email-ps@pks.im>

Signed-off-by: Patrick Steinhardt <ps@pks.im>
---
 builtin/branch.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/builtin/branch.c b/builtin/branch.c
index 0978287..c043cfc 100644
--- a/builtin/branch.c
+++ b/builtin/branch.c
@@ -570,7 +570,6 @@ static const char edit_description[] = "BRANCH_DESCRIPTION";
 
 static int edit_branch_description(const char *branch_name)
 {
-	int status;
 	struct strbuf buf = STRBUF_INIT;
 	struct strbuf name = STRBUF_INIT;
 
@@ -595,11 +594,11 @@ static int edit_branch_description(const char *branch_name)
 	strbuf_stripspace(&buf, 1);
 
 	strbuf_addf(&name, "branch.%s.description", branch_name);
-	status = git_config_set(name.buf, buf.len ? buf.buf : NULL);
+	git_config_set_or_die(name.buf, buf.len ? buf.buf : NULL);
 	strbuf_release(&name);
 	strbuf_release(&buf);
 
-	return status;
+	return 0;
 }
 
 int cmd_branch(int argc, const char **argv, const char *prefix)
-- 
2.7.1

  parent reply	other threads:[~2016-02-22 11:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-22 11:23 [PATCH v6 00/15] config: make git_config_set die on failure Patrick Steinhardt
2016-02-22 11:23 ` [PATCH v6 01/15] config: introduce set_or_die wrappers Patrick Steinhardt
2016-02-22 11:23 ` [PATCH v6 02/15] branch: report errors in tracking branch setup Patrick Steinhardt
2016-02-22 11:23 ` [PATCH v6 03/15] branch: die on config error when unsetting upstream Patrick Steinhardt
2016-02-22 11:23 ` Patrick Steinhardt [this message]
2016-02-22 11:23 ` [PATCH v6 05/15] submodule: die on config error when linking modules Patrick Steinhardt
2016-02-22 11:23 ` [PATCH v6 06/15] submodule--helper: die on config error when cloning module Patrick Steinhardt
2016-02-22 11:23 ` [PATCH v6 07/15] remote: die on config error when setting URL Patrick Steinhardt
2016-02-22 11:23 ` [PATCH v6 08/15] remote: die on config error when setting/adding branches Patrick Steinhardt
2016-02-22 11:23 ` [PATCH v6 09/15] remote: die on config error when manipulating remotes Patrick Steinhardt
2016-02-22 11:23 ` [PATCH v6 10/15] clone: die on config error in cmd_clone Patrick Steinhardt
2016-02-22 11:23 ` [PATCH v6 11/15] init-db: die on config errors when initializing empty repo Patrick Steinhardt
2016-02-22 11:23 ` [PATCH v6 12/15] sequencer: die on config error when saving replay opts Patrick Steinhardt
2016-02-22 11:23 ` [PATCH v6 13/15] compat: die when unable to set core.precomposeunicode Patrick Steinhardt
2016-02-22 11:23 ` [PATCH v6 14/15] config: rename git_config_set to git_config_set_gently Patrick Steinhardt
2016-02-22 11:23 ` [PATCH v6 15/15] config: rename git_config_set_or_die to git_config_set Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1456140216-24169-5-git-send-email-ps@pks.im \
    --to=ps@pks.im \
    --cc=blume.mike@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=larsxschneider@gmail.com \
    --cc=peff@peff.net \
    --cc=sbeller@google.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).