From: Stefan Beller <sbeller@google.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, Jens.Lehmann@web.de, dborowitz@google.com,
jacob.keller@gmail.com, Stefan Beller <sbeller@google.com>
Subject: [PATCH 0/2] Submodule harden fetches (WAS: submodule: Fetch the direct sha1 first)
Date: Mon, 22 Feb 2016 14:35:46 -0800 [thread overview]
Message-ID: <1456180548-20996-1-git-send-email-sbeller@google.com> (raw)
A simple patch evolves into a series!
First we'll fix a bug by adding the --objects switch to rev-list to
have a stricter check for the desired commit to be there. IIUC this
is not 100% right yet, but it improves the situation.
The second patch introduces an extra fetch in case the first fetch
did not yield the expected commit, using the pattern
# first 4 lines unchanged:
if $sha1's history and objects are incomplete:
fetch ;# normally just like we have done before
else
die ...
# new code:
if $sha1's history and objects are still incomplete:
fetch $sha1
else
die ...
Thanks,
Stefan
Stefan Beller (2):
submodule: Include check for objects when fetching
submodule: Try harder to fetch needed sha1 by direct fetching sha1
git-submodule.sh | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
--
2.7.0.rc0.34.ga06e0b3.dirty
next reply other threads:[~2016-02-22 22:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 22:35 Stefan Beller [this message]
2016-02-22 22:35 ` [PATCH 1/2] submodule: Include check for objects when fetching Stefan Beller
2016-02-22 22:54 ` Junio C Hamano
2016-02-22 23:06 ` Junio C Hamano
2016-02-22 23:18 ` Junio C Hamano
2016-02-22 22:35 ` [PATCH 2/2] submodule: Try harder to fetch needed sha1 by direct fetching sha1 Stefan Beller
2016-02-23 0:01 ` Junio C Hamano
2016-02-23 0:28 ` Stefan Beller
2016-02-23 6:38 ` Junio C Hamano
2016-02-24 3:32 ` [PATCH] " Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456180548-20996-1-git-send-email-sbeller@google.com \
--to=sbeller@google.com \
--cc=Jens.Lehmann@web.de \
--cc=dborowitz@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jacob.keller@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).