* [PATCH] refs: reduce the visibility of do_for_each_ref()
@ 2016-02-23 0:39 Ramsay Jones
2016-02-24 19:28 ` David Turner
0 siblings, 1 reply; 2+ messages in thread
From: Ramsay Jones @ 2016-02-23 0:39 UTC (permalink / raw)
To: David Turner; +Cc: Junio C Hamano, GIT Mailing-list
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi David,
Again, If you need to re-roll your 'dt/refs-backend-lmdb' branch ...
Thanks!
ATB,
Ramsay Jones
refs.c | 16 ++++++++--------
refs/refs-internal.h | 6 ------
2 files changed, 8 insertions(+), 14 deletions(-)
diff --git a/refs.c b/refs.c
index 337f110..bf70876 100644
--- a/refs.c
+++ b/refs.c
@@ -1236,6 +1236,14 @@ static int get_affected_refnames(struct ref_transaction *transaction,
return 0;
}
+static int do_for_each_ref(const char *submodule, const char *base,
+ each_ref_fn fn, int trim, int flags,
+ void *cb_data)
+{
+ return the_refs_backend->do_for_each_ref(submodule, base, fn, trim,
+ flags, cb_data);
+}
+
int for_each_ref(each_ref_fn fn, void *cb_data)
{
return do_for_each_ref(NULL, "", fn, 0, 0, cb_data);
@@ -1501,14 +1509,6 @@ int resolve_gitlink_ref(const char *path, const char *refname,
return the_refs_backend->resolve_gitlink_ref(path, refname, sha1);
}
-int do_for_each_ref(const char *submodule, const char *base,
- each_ref_fn fn, int trim, int flags,
- void *cb_data)
-{
- return the_refs_backend->do_for_each_ref(submodule, base, fn, trim,
- flags, cb_data);
-}
-
int for_each_reflog_ent_reverse(const char *refname, each_reflog_ent_fn fn,
void *cb_data)
{
diff --git a/refs/refs-internal.h b/refs/refs-internal.h
index ced6af4..4922e25 100644
--- a/refs/refs-internal.h
+++ b/refs/refs-internal.h
@@ -227,12 +227,6 @@ int do_for_each_per_worktree_ref(const char *submodule, const char *base,
each_ref_fn fn, int trim, int flags,
void *cb_data);
-/*
- * The common backend for the for_each_*ref* functions
- */
-int do_for_each_ref(const char *submodule, const char *base,
- each_ref_fn fn, int trim, int flags, void *cb_data);
-
/* refs backends */
typedef int ref_init_db_fn(int shared, struct strbuf *err);
typedef int ref_transaction_commit_fn(struct ref_transaction *transaction,
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] refs: reduce the visibility of do_for_each_ref()
2016-02-23 0:39 [PATCH] refs: reduce the visibility of do_for_each_ref() Ramsay Jones
@ 2016-02-24 19:28 ` David Turner
0 siblings, 0 replies; 2+ messages in thread
From: David Turner @ 2016-02-24 19:28 UTC (permalink / raw)
To: Ramsay Jones; +Cc: Junio C Hamano, GIT Mailing-list
Got it, thanks.
On Tue, 2016-02-23 at 00:39 +0000, Ramsay Jones wrote:
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi David,
>
> Again, If you need to re-roll your 'dt/refs-backend-lmdb' branch ...
>
> Thanks!
>
> ATB,
> Ramsay Jones
>
> refs.c | 16 ++++++++--------
> refs/refs-internal.h | 6 ------
> 2 files changed, 8 insertions(+), 14 deletions(-)
>
> diff --git a/refs.c b/refs.c
> index 337f110..bf70876 100644
> --- a/refs.c
> +++ b/refs.c
> @@ -1236,6 +1236,14 @@ static int get_affected_refnames(struct
> ref_transaction *transaction,
> return 0;
> }
>
> +static int do_for_each_ref(const char *submodule, const char *base,
> + each_ref_fn fn, int trim, int flags,
> + void *cb_data)
> +{
> + return the_refs_backend->do_for_each_ref(submodule, base,
> fn, trim,
> + flags, cb_data);
> +}
> +
> int for_each_ref(each_ref_fn fn, void *cb_data)
> {
> return do_for_each_ref(NULL, "", fn, 0, 0, cb_data);
> @@ -1501,14 +1509,6 @@ int resolve_gitlink_ref(const char *path,
> const char *refname,
> return the_refs_backend->resolve_gitlink_ref(path, refname,
> sha1);
> }
>
> -int do_for_each_ref(const char *submodule, const char *base,
> - each_ref_fn fn, int trim, int flags,
> - void *cb_data)
> -{
> - return the_refs_backend->do_for_each_ref(submodule, base,
> fn, trim,
> - flags, cb_data);
> -}
> -
> int for_each_reflog_ent_reverse(const char *refname,
> each_reflog_ent_fn fn,
> void *cb_data)
> {
> diff --git a/refs/refs-internal.h b/refs/refs-internal.h
> index ced6af4..4922e25 100644
> --- a/refs/refs-internal.h
> +++ b/refs/refs-internal.h
> @@ -227,12 +227,6 @@ int do_for_each_per_worktree_ref(const char
> *submodule, const char *base,
> each_ref_fn fn, int trim, int
> flags,
> void *cb_data);
>
> -/*
> - * The common backend for the for_each_*ref* functions
> - */
> -int do_for_each_ref(const char *submodule, const char *base,
> - each_ref_fn fn, int trim, int flags, void
> *cb_data);
> -
> /* refs backends */
> typedef int ref_init_db_fn(int shared, struct strbuf *err);
> typedef int ref_transaction_commit_fn(struct ref_transaction
> *transaction,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-24 19:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-23 0:39 [PATCH] refs: reduce the visibility of do_for_each_ref() Ramsay Jones
2016-02-24 19:28 ` David Turner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).