From: David Turner <dturner@twopensource.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>,
git mailing list <git@vger.kernel.org>
Subject: Re: [PATCH] refs: mark a file-local symbol as static
Date: Thu, 25 Feb 2016 15:09:20 -0500 [thread overview]
Message-ID: <1456430960.18017.49.camel@twopensource.com> (raw)
In-Reply-To: <56CF55ED.9040906@ramsayjones.plus.com>
On Thu, 2016-02-25 at 19:28 +0000, Ramsay Jones wrote:
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi David,
>
> No, you are not having flashbacks - you forgot to make the
> register_ref_storage_backend() function static. ;-)
Oops! Must have lost that in all of the rebasing! Will fix, thanks.
> BTW, I still have two symbols showing as exported but not used,
> namely:
>
> $ diff nsc psc1
> ...
> 32a35,36
> > refs.o - resolve_ref_unsafe_submodule
> > refs/files-backend.o - do_for_each_per_worktree_ref
> $
>
> Both of these symbols are used by the lmdb backend, so I'm assuming
> that
> they are part of the 'refs API' and will (may?) be used by other
> alternate
> reference backends. Is that the case?
Yes.
prev parent reply other threads:[~2016-02-25 20:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 19:28 [PATCH] refs: mark a file-local symbol as static Ramsay Jones
2016-02-25 20:09 ` David Turner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456430960.18017.49.camel@twopensource.com \
--to=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).