[PATCH] refs: mark a file-local symbol as static

[PATCH] refs: mark a file-local symbol as static

[Ramsay Jones]

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---

Hi David,

No, you are not having flashbacks - you forgot to make the
register_ref_storage_backend() function static. ;-)

BTW, I still have two symbols showing as exported but not used, namely:

    $ diff nsc psc1
    ...
    32a35,36
    > refs.o	- resolve_ref_unsafe_submodule
    > refs/files-backend.o	- do_for_each_per_worktree_ref
    $ 

Both of these symbols are used by the lmdb backend, so I'm assuming that
they are part of the 'refs API' and will (may?) be used by other alternate
reference backends. Is that the case?

(I don't have the time right now to look at the code!)

Thanks!

ATB,
Ramsay Jones


 refs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/refs.c b/refs.c
index 1c1d3ac..e448434 100644
--- a/refs.c
+++ b/refs.c
@@ -46,7 +46,7 @@ int ref_storage_backend_exists(const char *name)
 	return 0;
 }
 
-void register_ref_storage_backend(struct ref_storage_be *be)
+static void register_ref_storage_backend(struct ref_storage_be *be)
 {
 	be->next = refs_backends;
 	refs_backends = be;
-- 
2.7.0

Re: [PATCH] refs: mark a file-local symbol as static

[David Turner]

On Thu, 2016-02-25 at 19:28 +0000, Ramsay Jones wrote:
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
> 
> Hi David,
> 
> No, you are not having flashbacks - you forgot to make the
> register_ref_storage_backend() function static. ;-)

Oops!  Must have lost that in all of the rebasing!  Will fix, thanks.

> BTW, I still have two symbols showing as exported but not used,
> namely:
> 
>     $ diff nsc psc1
>     ...
>     32a35,36
>     > refs.o	- resolve_ref_unsafe_submodule
>     > refs/files-backend.o	- do_for_each_per_worktree_ref
>     $ 
> 
> Both of these symbols are used by the lmdb backend, so I'm assuming
> that
> they are part of the 'refs API' and will (may?) be used by other
> alternate
> reference backends. Is that the case?

Yes.