From: Gabriel Souza Franco <gabrielfrancosouza@gmail.com>
To: git@vger.kernel.org
Cc: Gabriel Souza Franco <gabrielfrancosouza@gmail.com>
Subject: [PATCH] fetch-pack: fix unadvertised requests validation
Date: Sat, 27 Feb 2016 09:43:54 -0300 [thread overview]
Message-ID: <1456577034-6494-1-git-send-email-gabrielfrancosouza@gmail.com> (raw)
Check was introduced in b791642 (filter_ref: avoid overwriting
ref->old_sha1 with garbage, 2015-03-19), but was always false because
ref->old_oid.hash is empty in this case. Instead copy sha1 from ref->name.
Signed-off-by: Gabriel Souza Franco <gabrielfrancosouza@gmail.com>
---
fetch-pack.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fetch-pack.c b/fetch-pack.c
index 01e34b6..83b937b 100644
--- a/fetch-pack.c
+++ b/fetch-pack.c
@@ -569,11 +569,11 @@ static void filter_refs(struct fetch_pack_args *args,
if (ref->matched)
continue;
if (get_sha1_hex(ref->name, sha1) ||
- ref->name[40] != '\0' ||
- hashcmp(sha1, ref->old_oid.hash))
+ ref->name[40] != '\0')
continue;
ref->matched = 1;
+ hashcpy(ref->old_oid.hash, sha1);
*newtail = copy_ref(ref);
newtail = &(*newtail)->next;
}
--
2.7.1
next reply other threads:[~2016-02-27 12:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-27 12:43 Gabriel Souza Franco [this message]
2016-02-27 18:25 ` [PATCH] fetch-pack: fix unadvertised requests validation Junio C Hamano
2016-02-27 18:32 ` Junio C Hamano
2016-02-27 18:38 ` Junio C Hamano
2016-02-27 19:07 ` Jeff King
2016-02-27 19:19 ` Jeff King
2016-02-27 20:28 ` Gabriel Souza Franco
2016-02-27 20:32 ` [PATCH] fetch-pack: fix object_id of exact sha1 Gabriel Souza Franco
2016-02-27 22:12 ` Jeff King
2016-02-27 22:23 ` Gabriel Souza Franco
2016-02-28 19:29 ` Junio C Hamano
2016-02-28 22:22 ` [PATCH v2] " Gabriel Souza Franco
2016-02-29 8:30 ` Johannes Schindelin
2016-02-29 10:00 ` Jeff King
2016-03-01 2:08 ` Gabriel Souza Franco
2016-03-01 2:12 ` [PATCH v3] " Gabriel Souza Franco
2016-03-01 4:54 ` Jeff King
2016-03-03 23:35 ` Gabriel Souza Franco
2016-03-04 0:50 ` Jeff King
2016-03-05 1:11 ` [PATCH v4] " Gabriel Souza Franco
2016-03-05 16:59 ` Jeff King
2016-03-05 18:54 ` Junio C Hamano
2016-03-05 19:34 ` [PATCH] fetch-pack: update the documentation for "<refs>..." arguments Gabriel Souza Franco
2016-03-05 19:35 ` Junio C Hamano
2016-03-01 4:40 ` [PATCH v2] fetch-pack: fix object_id of exact sha1 Jeff King
2016-02-29 9:50 ` [PATCH] " Jeff King
2016-02-27 22:08 ` [PATCH] fetch-pack: fix unadvertised requests validation Jeff King
2016-02-28 19:14 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456577034-6494-1-git-send-email-gabrielfrancosouza@gmail.com \
--to=gabrielfrancosouza@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).