From: Karthik Nayak <karthik.188@gmail.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, Karthik Nayak <Karthik.188@gmail.com>
Subject: [PATCH 11/15] ref-filter: add support for %(refname:dir) and %(refname:base)
Date: Sun, 6 Mar 2016 17:34:58 +0530 [thread overview]
Message-ID: <1457265902-7949-12-git-send-email-Karthik.188@gmail.com> (raw)
In-Reply-To: <1457265902-7949-1-git-send-email-Karthik.188@gmail.com>
Add the options `:dir` and `:base` to the %(refname) atom. The `:dir`
option gives the directory (the part after $GIT_DIR/) of the ref without
the refname. The `:base` option gives the base directory of the given
ref (i.e. the directory following $GIT_DIR/refs/).
Add tests and documentation for the same.
Signed-off-by: Karthik Nayak <Karthik.188@gmail.com>
---
Documentation/git-for-each-ref.txt | 4 +++-
ref-filter.c | 28 +++++++++++++++++++++++++---
t/t6300-for-each-ref.sh | 2 ++
3 files changed, 30 insertions(+), 4 deletions(-)
diff --git a/Documentation/git-for-each-ref.txt b/Documentation/git-for-each-ref.txt
index 0658c3f..193e99e 100644
--- a/Documentation/git-for-each-ref.txt
+++ b/Documentation/git-for-each-ref.txt
@@ -96,7 +96,9 @@ refname::
slash-separated path components from the front of the refname
(e.g., `%(refname:strip=2)` turns `refs/tags/foo` into `foo`.
`<N>` must be a positive integer. If a displayed ref has fewer
- components than `<N>`, the command aborts with an error.
+ components than `<N>`, the command aborts with an error. For the base
+ directory of the ref (i.e. foo in refs/foo/bar/boz) append
+ `:base`. For the entire directory path append `:dir`.
objecttype::
The type of the object (`blob`, `tree`, `commit`, `tag`).
diff --git a/ref-filter.c b/ref-filter.c
index 2393800..45f9d16 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -60,7 +60,7 @@ static struct used_atom {
} objectname;
enum { S_FULL, S_SHORT } symref;
struct {
- enum { R_NORMAL, R_SHORT, R_STRIP } option;
+ enum { R_BASE, R_DIR, R_NORMAL, R_SHORT, R_STRIP } option;
unsigned int strip;
} refname;
} u;
@@ -227,7 +227,11 @@ static void refname_atom_parser(struct used_atom *atom, const char *arg)
if (strtoul_ui(arg, 10, &atom->u.refname.strip) ||
atom->u.refname.strip <= 0)
die(_("positive value expected refname:strip=%s"), arg);
- } else
+ } else if (!strcmp(arg, "dir"))
+ atom->u.contents.option = R_DIR;
+ else if (!strcmp(arg, "base"))
+ atom->u.contents.option = R_BASE;
+ else
die(_("unrecognized %%(refname) argument: %s"), arg);
}
@@ -1166,7 +1170,25 @@ static const char *get_refname(struct used_atom *atom, struct ref_array_item *re
return shorten_unambiguous_ref(ref->refname, warn_ambiguous_refs);
else if (atom->u.refname.option == R_STRIP)
return strip_ref_components(ref->refname, atom->u.refname.strip);
- else
+ else if (atom->u.refname.option == R_BASE) {
+ const char *sp, *ep;
+
+ if (skip_prefix(ref->refname, "refs/", &sp)) {
+ ep = strchr(sp, '/');
+ if (!ep)
+ return "";
+ return xstrndup(sp, ep - sp);
+ }
+ return "";
+ } else if (atom->u.refname.option == R_DIR) {
+ const char *sp, *ep;
+
+ sp = ref->refname;
+ ep = strrchr(sp, '/');
+ if (!ep)
+ return "";
+ return xstrndup(sp, ep - sp);
+ } else
return ref->refname;
}
diff --git a/t/t6300-for-each-ref.sh b/t/t6300-for-each-ref.sh
index b06ea1c..36d32d7 100755
--- a/t/t6300-for-each-ref.sh
+++ b/t/t6300-for-each-ref.sh
@@ -53,6 +53,8 @@ test_atom head refname refs/heads/master
test_atom head refname:short master
test_atom head refname:strip=1 heads/master
test_atom head refname:strip=2 master
+test_atom head refname:dir refs/heads
+test_atom head refname:base heads
test_atom head upstream refs/remotes/origin/master
test_atom head upstream:short origin/master
test_atom head push refs/remotes/myfork/master
--
2.7.2
next prev parent reply other threads:[~2016-03-06 12:05 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-06 12:04 [PATCH 00/15] port branch.c to use ref-filter's printing options Karthik Nayak
2016-03-06 12:04 ` [PATCH 01/15] ref-filter: implement %(if), %(then), and %(else) atoms Karthik Nayak
2016-03-06 12:04 ` [PATCH 02/15] ref-filter: implement %(if:equals=<string>) and %(if:notequals=<string>) Karthik Nayak
2016-03-07 22:49 ` Junio C Hamano
2016-03-08 5:41 ` Karthik Nayak
2016-03-08 6:04 ` Junio C Hamano
2016-03-08 6:09 ` Karthik Nayak
2016-03-06 12:04 ` [PATCH 03/15] ref-filter: modify "%(objectname:short)" to take length Karthik Nayak
2016-03-06 12:04 ` [PATCH 04/15] ref-filter: move get_head_description() from branch.c Karthik Nayak
2016-03-06 12:04 ` [PATCH 05/15] ref-filter: introduce format_ref_array_item() Karthik Nayak
2016-03-06 12:04 ` [PATCH 06/15] ref-filter: make %(upstream:track) prints "[gone]" for invalid upstreams Karthik Nayak
2016-03-08 1:55 ` Jacob Keller
2016-03-08 6:10 ` Karthik Nayak
2016-03-06 12:04 ` [PATCH 07/15] ref-filter: add support for %(upstream:track,nobracket) Karthik Nayak
2016-03-06 12:04 ` [PATCH 08/15] ref-filter: make "%(symref)" atom work with the ':short' modifier Karthik Nayak
2016-03-07 23:08 ` Junio C Hamano
2016-03-08 1:56 ` Jacob Keller
2016-03-08 6:21 ` Karthik Nayak
2016-03-08 20:19 ` Junio C Hamano
2016-03-09 11:17 ` Karthik Nayak
2016-03-06 12:04 ` [PATCH 09/15] ref-filter: introduce symref_atom_parser() Karthik Nayak
2016-03-06 12:04 ` [PATCH 10/15] ref-filter: introduce refname_atom_parser() Karthik Nayak
2016-03-06 12:04 ` Karthik Nayak [this message]
2016-03-06 12:04 ` [PATCH 12/15] ref-filter: allow porcelain to translate messages in the output Karthik Nayak
2016-03-06 12:05 ` [PATCH 13/15] branch, tag: use porcelain output Karthik Nayak
2016-03-06 12:05 ` [PATCH 14/15] branch: use ref-filter printing APIs Karthik Nayak
2016-03-07 23:11 ` Junio C Hamano
2016-03-06 12:05 ` [PATCH 15/15] branch: implement '--format' option Karthik Nayak
2016-03-08 1:58 ` Jacob Keller
2016-03-15 16:38 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457265902-7949-12-git-send-email-Karthik.188@gmail.com \
--to=karthik.188@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).