From: Jim Klimov <jim@jimklimov.com>
To: git@vger.kernel.org
Cc: Jim Klimov <jim@jimklimov.com>
Subject: [PATCH 6/6] gitweb.perl : the optional DEBUG functionality is now unit-tested
Date: Fri, 11 Mar 2016 14:24:49 +0100 [thread overview]
Message-ID: <1457702689-9084-6-git-send-email-jim@jimklimov.com> (raw)
In-Reply-To: <1457702689-9084-1-git-send-email-jim@jimklimov.com>
---
t/t9502-gitweb-standalone-parse-output.sh | 35 +++++++++++++++++++++++++++++++
1 file changed, 35 insertions(+)
diff --git a/t/t9502-gitweb-standalone-parse-output.sh b/t/t9502-gitweb-standalone-parse-output.sh
index a2ae5c4..4f1ddbf 100755
--- a/t/t9502-gitweb-standalone-parse-output.sh
+++ b/t/t9502-gitweb-standalone-parse-output.sh
@@ -253,6 +253,41 @@ test_expect_success 'snapshot certain objects: have expected content in xx/test
test_debug 'cat gitweb.headers && cat file_list'
# ----------------------------------------------------------------------
+# optional debugging in log, if allowed on server and requested by user
+
+test_expect_success 'snapshot: debugging logged as forbidden when not defined in server environment' '
+ rm -f gitweb.body gitweb.log gitweb.headers gitweb.output &&
+ gitweb_run "p=.git;a=snapshot;h=master;sf=tar;debug=yes" &&
+ grep "GITWEB_MAY_DEBUG=yes is not set" < gitweb.log >/dev/null
+'
+test_debug 'cat gitweb.headers gitweb.log'
+
+test_expect_success 'snapshot: debugging logged as forbidden when not allowed in server environment' '
+ rm -f gitweb.body gitweb.log gitweb.headers gitweb.output &&
+ GITWEB_MAY_DEBUG=xxx && export GITWEB_MAY_DEBUG &&
+ gitweb_run "p=.git;a=snapshot;h=master;sf=tar;debug=yes" &&
+ grep "GITWEB_MAY_DEBUG=yes is not set" < gitweb.log >/dev/null
+'
+test_debug 'cat gitweb.headers gitweb.log'
+
+test_expect_success 'snapshot: debugging present when allowed in server environment' '
+ rm -f gitweb.body gitweb.log gitweb.headers gitweb.output &&
+ GITWEB_MAY_DEBUG=yes && export GITWEB_MAY_DEBUG &&
+ gitweb_run "p=.git;a=snapshot;h=master;sf=tar;debug=yes" &&
+ ! grep "GITWEB_MAY_DEBUG=yes is not set" < gitweb.log >/dev/null &&
+ grep "git-archive" < gitweb.log >/dev/null
+'
+test_debug 'cat gitweb.headers gitweb.log'
+
+test_expect_success 'snapshot: debugging absent when not allowed in server environment' '
+ rm -f gitweb.body gitweb.log gitweb.headers gitweb.output &&
+ GITWEB_MAY_DEBUG=xxx && export GITWEB_MAY_DEBUG &&
+ gitweb_run "p=.git;a=snapshot;h=master;sf=tar;debug=yes" &&
+ ! grep "git-archive" < gitweb.log >/dev/null
+'
+test_debug 'cat gitweb.headers gitweb.log'
+
+# ----------------------------------------------------------------------
# forks of projects
test_expect_success 'forks: setup' '
--
2.1.4
prev parent reply other threads:[~2016-03-11 13:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 13:24 [PATCH 1/6] gitweb.perl : added ability to "git archive" just certain paths (files or subdirs, not whole repo) via gitweb interface Jim Klimov
2016-03-11 13:24 ` [PATCH 2/6] gitweb.perl : added ability to debug requests coming through gitweb interface by adding an option to request URL (also requires server-side envvar "GITWEB_MAY_DEBUG=yes") Jim Klimov
2016-03-11 13:24 ` [PATCH 3/6] gitweb.perl : added ability to DEBUG progression through "git archive" Jim Klimov
2016-03-11 13:24 ` [PATCH 4/6] gitweb.perl support for snapshots with lists of specified files is now tested Jim Klimov
2016-03-11 13:24 ` [PATCH 5/6] gitweb.perl changed (and tested) to return HTTP-404 when missing objects are requested via snapshot Jim Klimov
2016-03-11 13:24 ` Jim Klimov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457702689-9084-6-git-send-email-jim@jimklimov.com \
--to=jim@jimklimov.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).