* [PATCH] submodule-config: use hashmap_iter_init()
@ 2016-03-15 18:25 Alexander Kuleshov
2016-03-15 18:58 ` Eric Sunshine
0 siblings, 1 reply; 4+ messages in thread
From: Alexander Kuleshov @ 2016-03-15 18:25 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Git, Alexander Kuleshov
from the <hashmap.h> for simplification.
---
submodule-config.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/submodule-config.c b/submodule-config.c
index b82d1fb..8ac5031 100644
--- a/submodule-config.c
+++ b/submodule-config.c
@@ -405,8 +405,7 @@ static const struct submodule *config_from(struct submodule_cache *cache,
struct hashmap_iter iter;
struct submodule_entry *entry;
- hashmap_iter_init(&cache->for_name, &iter);
- entry = hashmap_iter_next(&iter);
+ entry = hashmap_iter_first(&cache->for_name, &iter);
if (!entry)
return NULL;
return entry->config;
--
2.8.0.rc2.216.g1477fb2.dirty
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] submodule-config: use hashmap_iter_init()
2016-03-15 18:25 [PATCH] submodule-config: use hashmap_iter_init() Alexander Kuleshov
@ 2016-03-15 18:58 ` Eric Sunshine
2016-03-15 19:08 ` Stefan Beller
0 siblings, 1 reply; 4+ messages in thread
From: Eric Sunshine @ 2016-03-15 18:58 UTC (permalink / raw)
To: Alexander Kuleshov; +Cc: Junio C Hamano, Git
On Tue, Mar 15, 2016 at 2:25 PM, Alexander Kuleshov
<kuleshovmail@gmail.com> wrote:
> submodule-config: use hashmap_iter_init()
Did you mean s/init/first/ ?
> from the <hashmap.h> for simplification.
Sentence fragment...
Missing sign-off.
> ---
> diff --git a/submodule-config.c b/submodule-config.c
> index b82d1fb..8ac5031 100644
> --- a/submodule-config.c
> +++ b/submodule-config.c
> @@ -405,8 +405,7 @@ static const struct submodule *config_from(struct submodule_cache *cache,
> struct hashmap_iter iter;
> struct submodule_entry *entry;
>
> - hashmap_iter_init(&cache->for_name, &iter);
> - entry = hashmap_iter_next(&iter);
> + entry = hashmap_iter_first(&cache->for_name, &iter);
> if (!entry)
> return NULL;
> return entry->config;
> --
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] submodule-config: use hashmap_iter_init()
2016-03-15 18:58 ` Eric Sunshine
@ 2016-03-15 19:08 ` Stefan Beller
2016-03-15 19:10 ` Alexander Kuleshov
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Beller @ 2016-03-15 19:08 UTC (permalink / raw)
To: Eric Sunshine; +Cc: Alexander Kuleshov, Junio C Hamano, Git
On Tue, Mar 15, 2016 at 11:58 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:
> On Tue, Mar 15, 2016 at 2:25 PM, Alexander Kuleshov
> <kuleshovmail@gmail.com> wrote:
>> submodule-config: use hashmap_iter_init()
>
> Did you mean s/init/first/ ?
>
>> from the <hashmap.h> for simplification.
>
> Sentence fragment...
>
> Missing sign-off.
>
>> ---
>> diff --git a/submodule-config.c b/submodule-config.c
>> index b82d1fb..8ac5031 100644
>> --- a/submodule-config.c
>> +++ b/submodule-config.c
>> @@ -405,8 +405,7 @@ static const struct submodule *config_from(struct submodule_cache *cache,
>> struct hashmap_iter iter;
>> struct submodule_entry *entry;
>>
>> - hashmap_iter_init(&cache->for_name, &iter);
>> - entry = hashmap_iter_next(&iter);
>> + entry = hashmap_iter_first(&cache->for_name, &iter);
The change looks correct to me. But as Eric said, the commit message
needs work and a sign off. With that,
Reviewed-by: Stefan Beller <sbeller@google.com>
Thanks,
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] submodule-config: use hashmap_iter_init()
2016-03-15 19:08 ` Stefan Beller
@ 2016-03-15 19:10 ` Alexander Kuleshov
0 siblings, 0 replies; 4+ messages in thread
From: Alexander Kuleshov @ 2016-03-15 19:10 UTC (permalink / raw)
To: Stefan Beller; +Cc: Eric Sunshine, Junio C Hamano, Git
On Wed, Mar 16, 2016 at 1:08 AM, Stefan Beller <sbeller@google.com> wrote:
> The change looks correct to me. But as Eric said, the commit message
> needs work and a sign off. With that,
> Reviewed-by: Stefan Beller <sbeller@google.com>
Ah, yes, forgot to pass `-s` to commit command. Sorry for noise guys,
will resend
the patch.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-03-15 19:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-15 18:25 [PATCH] submodule-config: use hashmap_iter_init() Alexander Kuleshov
2016-03-15 18:58 ` Eric Sunshine
2016-03-15 19:08 ` Stefan Beller
2016-03-15 19:10 ` Alexander Kuleshov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).