git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2/GSoC 1/4] path.c: implement strbuf_mkpath()
@ 2016-03-17 16:48 Hui Yiqun
  2016-03-17 16:48 ` [PATCH v2/GSoC 2/4] path.c: implement xdg_runtime_dir() Hui Yiqun
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Hui Yiqun @ 2016-03-17 16:48 UTC (permalink / raw)
  To: git; +Cc: gitster, pickfire, peff, Hui Yiqun

Common logic of mkpath() and mkpathdup() are collected into a
new do_mkpath(). Then, based on do_mkpath(), strbuf_mkpath() is
implemented.

Signed-off-by: Hui Yiqun <huiyiqun@gmail.com>
---
 cache.h |  2 ++
 path.c  | 21 +++++++++++++++++----
 2 files changed, 19 insertions(+), 4 deletions(-)

diff --git a/cache.h b/cache.h
index b829410..ef843c1 100644
--- a/cache.h
+++ b/cache.h
@@ -781,6 +781,8 @@ extern char *git_pathdup(const char *fmt, ...)
 	__attribute__((format (printf, 1, 2)));
 extern char *mkpathdup(const char *fmt, ...)
 	__attribute__((format (printf, 1, 2)));
+extern void strbuf_mkpath(struct strbuf *sb, const char *fmt, ...)
+	__attribute__((format (printf, 2, 3)));
 extern char *git_pathdup_submodule(const char *path, const char *fmt, ...)
 	__attribute__((format (printf, 2, 3)));
 
diff --git a/path.c b/path.c
index 8b7e168..699af68 100644
--- a/path.c
+++ b/path.c
@@ -433,14 +433,19 @@ char *git_pathdup(const char *fmt, ...)
 	return strbuf_detach(&path, NULL);
 }
 
+static void do_mkpath(struct strbuf *buf, const char *fmt, va_list args)
+{
+	strbuf_vaddf(buf, fmt, args);
+	strbuf_cleanup_path(buf);
+}
+
 char *mkpathdup(const char *fmt, ...)
 {
 	struct strbuf sb = STRBUF_INIT;
 	va_list args;
 	va_start(args, fmt);
-	strbuf_vaddf(&sb, fmt, args);
+	do_mkpath(&sb, fmt, args);
 	va_end(args);
-	strbuf_cleanup_path(&sb);
 	return strbuf_detach(&sb, NULL);
 }
 
@@ -449,9 +454,17 @@ const char *mkpath(const char *fmt, ...)
 	va_list args;
 	struct strbuf *pathname = get_pathname();
 	va_start(args, fmt);
-	strbuf_vaddf(pathname, fmt, args);
+	do_mkpath(pathname, fmt, args);
+	va_end(args);
+	return pathname->buf;
+}
+
+void strbuf_mkpath(struct strbuf *buf, const char *fmt, ...)
+{
+	va_list args;
+	va_start(args, fmt);
+	do_mkpath(buf, fmt, args);
 	va_end(args);
-	return cleanup_path(pathname->buf);
 }
 
 static void do_submodule_path(struct strbuf *buf, const char *path,
-- 
2.7.3

^ permalink raw reply related	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-03-18  5:22 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-17 16:48 [PATCH v2/GSoC 1/4] path.c: implement strbuf_mkpath() Hui Yiqun
2016-03-17 16:48 ` [PATCH v2/GSoC 2/4] path.c: implement xdg_runtime_dir() Hui Yiqun
2016-03-17 18:13   ` Jeff King
2016-03-17 16:48 ` [PATCH v2/GSoC 3/4] git-credential-cache: put socket to xdg-compatible path Hui Yiqun
2016-03-17 16:48 ` [PATCH v2/GSoC 4/4] t0301: test credential-cache support of XDG_RUNTIME_DIR Hui Yiqun
2016-03-17 18:08   ` Jeff King
2016-03-18  4:38     ` 惠轶群
2016-03-18  5:01       ` Jeff King
2016-03-18  5:22         ` 惠轶群

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).