From: Hui Yiqun <huiyiqun@gmail.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, pickfire@riseup.net, peff@peff.net,
Hui Yiqun <huiyiqun@gmail.com>
Subject: [PATCH v2/GSoC 4/4] t0301: test credential-cache support of XDG_RUNTIME_DIR
Date: Fri, 18 Mar 2016 00:48:46 +0800 [thread overview]
Message-ID: <1458233326-7735-4-git-send-email-huiyiqun@gmail.com> (raw)
In-Reply-To: <1458233326-7735-1-git-send-email-huiyiqun@gmail.com>
t0301 now tests git-credential-cache support for XDG user-specific
runtime file $XDG_RUNTIME_DIR/git/credential.sock. Specifically:
* if $XDG_RUNTIME_DIR exists, use socket at
`$XDG_RUNTIME_DIR/git/credential-cache.sock`.
* otherwise, `/tmp/git-$uid/credential-cache.sock` is taken.
Signed-off-by: Hui Yiqun <huiyiqun@gmail.com>
---
t/t0301-credential-cache.sh | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/t/t0301-credential-cache.sh b/t/t0301-credential-cache.sh
index 82c8411..892d1ba 100755
--- a/t/t0301-credential-cache.sh
+++ b/t/t0301-credential-cache.sh
@@ -12,7 +12,34 @@ test -z "$NO_UNIX_SOCKETS" || {
# don't leave a stale daemon running
trap 'code=$?; git credential-cache exit; (exit $code); die' EXIT
+test_expect_success 'set $XDG_RUNTIME_DIR' '
+ XDG_RUNTIME_DIR=$HOME/xdg_runtime/
+'
+
+helper_test cache
+
+test_expect_success 'when $XDG_RUNTIME_DIR is set, `$XDG_RUNTIME_DIR/git` are used' '
+ test_path_is_missing "/tmp/git-$(id -u)/git/credential-cache.sock" &&
+ test -S "$HOME/xdg_runtime/git/credential-cache.sock"
+'
+
+test_expect_success 'force git-credential-cache to exit so that socket disappear' '
+ git credential-cache exit &&
+ test_path_is_missing "$XDG_RUNTIME_DIR/git/credential-cache.sock" &&
+ unset XDG_RUNTIME_DIR
+'
+
helper_test cache
+
+test_expect_success 'when $XDG_RUNTIME_DIR is not set, `/tmp/git-$(id -u) is used' '
+ test -S "/tmp/git-$(id -u)/credential-cache.sock"
+'
+
+# TODO: if $XDG_RUNTIME_DIR/git/ exists, but has wrong permission and ownership,
+# `helper_test cache` must fail.
+
+# TODO: check whether `--socket` works
+
helper_test_timeout cache --timeout=1
# we can't rely on our "trap" above working after test_done,
--
2.7.3
next prev parent reply other threads:[~2016-03-17 16:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 16:48 [PATCH v2/GSoC 1/4] path.c: implement strbuf_mkpath() Hui Yiqun
2016-03-17 16:48 ` [PATCH v2/GSoC 2/4] path.c: implement xdg_runtime_dir() Hui Yiqun
2016-03-17 18:13 ` Jeff King
2016-03-17 16:48 ` [PATCH v2/GSoC 3/4] git-credential-cache: put socket to xdg-compatible path Hui Yiqun
2016-03-17 16:48 ` Hui Yiqun [this message]
2016-03-17 18:08 ` [PATCH v2/GSoC 4/4] t0301: test credential-cache support of XDG_RUNTIME_DIR Jeff King
2016-03-18 4:38 ` 惠轶群
2016-03-18 5:01 ` Jeff King
2016-03-18 5:22 ` 惠轶群
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458233326-7735-4-git-send-email-huiyiqun@gmail.com \
--to=huiyiqun@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=pickfire@riseup.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).