From: "SZEDER Gábor" <szeder@ira.uka.de>
To: Jeff King <peff@peff.net>
Cc: "SZEDER Gábor" <szeder@ira.uka.de>,
"Stefan Beller" <sbeller@google.com>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Pranit Bauva" <pranit.bauva@gmail.com>,
"Git List" <git@vger.kernel.org>
Subject: Re: parse-options does not recognize "unspecified" behavior
Date: Sat, 19 Mar 2016 12:25:35 +0100 [thread overview]
Message-ID: <1458386735-8038-1-git-send-email-szeder@ira.uka.de> (raw)
In-Reply-To: <20160317014310.GA12830@sigill.intra.peff.net>
> Yes, I think in general, "-v" and "-q" should work as opposites. But
> that is not the case with commit, where "-v" and "-q" operate on totally
> separate messages. I think that is a UX mistake, and we would not do
> it that way if designing from scratch. But we're stuck with it for
> historical reasons (I'd probably name "--verbose" as "--show-diff" or
> something if writing it today).
Yeah, as a long-time 'git commit -v' user I never really thought about
the name of the option, but when I pointed out the multiple verbose
levels it struck me as a rather unfortunate name for this feature,
too. Oh, well, we are stuck with it indeed.
However, that doesn't mean that we have to spread this badly chosen
name from options to config variables, does it? I think that if we
are going to define a new config variable today, then it should be
named properly, and it's better not to call it 'commit.verbose', but
'commit.showDiff' or something. Perhaps we could even define two new
config variables: 'commit.showDiff' for the diff of the changes to be
committed (= '-v'), and 'commit.showUnstagedDiff' for the - wait for
it! - unstaged changes (= '-v -v'). Not sure about the variable
names, though, because "plain" 'git diff' shows unstaged changes,
while 'git diff --cached' shows staged changes.
Furthermore, it doesn't mean that we can't add properly named command
line option(s) and state that '-v|--verbose' is a synonym to
'--show-diff' (maybe even deprecate '--verbose'), but I don't want to
squeeze even more into a GSOC micro project.
Gábor
next prev parent reply other threads:[~2016-03-19 11:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 19:51 parse-options does not recognize "unspecified" behavior Pranit Bauva
2016-03-16 20:49 ` Jeff King
2016-03-16 21:06 ` Pranit Bauva
2016-03-16 21:23 ` Jeff King
2016-03-16 21:37 ` Eric Sunshine
2016-03-16 21:41 ` Pranit Bauva
2016-03-16 21:44 ` Jeff King
2016-03-16 21:53 ` Stefan Beller
2016-03-16 23:16 ` Jeff King
2016-03-16 23:33 ` Stefan Beller
2016-03-17 1:43 ` Jeff King
2016-03-17 5:32 ` Eric Sunshine
2016-03-17 5:40 ` Jeff King
2016-03-19 11:25 ` SZEDER Gábor [this message]
2016-03-19 16:55 ` Pranit Bauva
2016-03-25 14:58 ` SZEDER Gábor
2016-03-25 15:03 ` Pranit Bauva
2016-03-16 21:37 ` Pranit Bauva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458386735-8038-1-git-send-email-szeder@ira.uka.de \
--to=szeder@ira.uka.de \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=pranit.bauva@gmail.com \
--cc=sbeller@google.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).