* [PATCH] (exit 1) is silly
@ 2016-03-22 15:47 izabera
2016-03-22 16:16 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: izabera @ 2016-03-22 15:47 UTC (permalink / raw)
To: git
Signed-off-by: izabera <izaberina@gmail.com>
---
GIT-VERSION-GEN | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN
index b5072a2..17b6ef4 100755
--- a/GIT-VERSION-GEN
+++ b/GIT-VERSION-GEN
@@ -14,7 +14,7 @@ then
elif test -d ${GIT_DIR:-.git} -o -f .git &&
VN=$(git describe --match "v[0-9]*" --abbrev=7 HEAD 2>/dev/null) &&
case "$VN" in
- *$LF*) (exit 1) ;;
+ *$LF*) false ;;
v[0-9]*)
git update-index -q --refresh
test -z "$(git diff-index --name-only HEAD --)" ||
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] (exit 1) is silly
2016-03-22 15:47 [PATCH] (exit 1) is silly izabera
@ 2016-03-22 16:16 ` Junio C Hamano
2016-03-22 17:08 ` Sebastian Schuberth
0 siblings, 1 reply; 4+ messages in thread
From: Junio C Hamano @ 2016-03-22 16:16 UTC (permalink / raw)
To: izabera; +Cc: git
izabera <izaberina@gmail.com> writes:
> Signed-off-by: izabera <izaberina@gmail.com>
> ---
> GIT-VERSION-GEN | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN
> index b5072a2..17b6ef4 100755
> --- a/GIT-VERSION-GEN
> +++ b/GIT-VERSION-GEN
> @@ -14,7 +14,7 @@ then
> elif test -d ${GIT_DIR:-.git} -o -f .git &&
> VN=$(git describe --match "v[0-9]*" --abbrev=7 HEAD 2>/dev/null) &&
> case "$VN" in
> - *$LF*) (exit 1) ;;
> + *$LF*) false ;;
> v[0-9]*)
> git update-index -q --refresh
> test -z "$(git diff-index --name-only HEAD --)" ||
IMO, this is such a minor thing that once it _is_ in the tree, it's
not really worth the patch noise to go and fix it up.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] (exit 1) is silly
2016-03-22 16:16 ` Junio C Hamano
@ 2016-03-22 17:08 ` Sebastian Schuberth
2016-03-22 17:45 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Sebastian Schuberth @ 2016-03-22 17:08 UTC (permalink / raw)
To: Junio C Hamano, izabera; +Cc: git
On 3/22/2016 17:16, Junio C Hamano wrote:
> IMO, this is such a minor thing that once it _is_ in the tree, it's
> not really worth the patch noise to go and fix it up.
IMO, instead of writing this you could have just accepted the patch,
reducing the patch noise ;-)
Regards,
Sebastian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] (exit 1) is silly
2016-03-22 17:08 ` Sebastian Schuberth
@ 2016-03-22 17:45 ` Junio C Hamano
0 siblings, 0 replies; 4+ messages in thread
From: Junio C Hamano @ 2016-03-22 17:45 UTC (permalink / raw)
To: Sebastian Schuberth; +Cc: izabera, git
Sebastian Schuberth <sschuberth@gmail.com> writes:
> On 3/22/2016 17:16, Junio C Hamano wrote:
>
>> IMO, this is such a minor thing that once it _is_ in the tree, it's
>> not really worth the patch noise to go and fix it up.
>
> IMO, instead of writing this you could have just accepted the patch,
> reducing the patch noise ;-)
"patch noise" does not mean the volume of the list traffic. It is
the number of pointless changes in the history of the project, and
accepting this patch would _encourage_ similar pointless changes,
i.e. "patch noise".
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-03-22 17:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-22 15:47 [PATCH] (exit 1) is silly izabera
2016-03-22 16:16 ` Junio C Hamano
2016-03-22 17:08 ` Sebastian Schuberth
2016-03-22 17:45 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).