git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: santiago@nyu.edu
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
	Eric Sunshine <sunshine@sunshineco.com>
Subject: [PATCH v3 0/4] tag: move PGP verification code to tag.c
Date: Sat,  2 Apr 2016 19:16:11 -0400	[thread overview]
Message-ID: <1459638975-17705-1-git-send-email-santiago@nyu.edu> (raw)

This is a follow up of [1] and [2]:

v3 (this):
Thanks Eric, Jeff, for the feedback.

 * I separated the patch in multiple sub-patches.
 * I compared the behavior of previous git tag -v and git verify-tag 
   invocations to make sure the behavior is the same
 * I dropped the multi-line comment, as suggested.
 * I fixed the issue with the missing brackets in the while (this is 
   now detected by the test).

v2:

 * I moved the pgp-verification code to tag.c 
 * I added extra arguments so git tag -v and git verify-tag both work
   with the same function
 * Relocated the SIGPIPE handling code in verify-tag to gpg-interface

v1:
 
The verify tag function is just a thin wrapper around the verify-tag
command. We can avoid one fork call by doing the verification inside
the tag builtin instead.


This applies on v2.8.0.

Thanks!
-Santiago

[1]
http://git.661346.n2.nabble.com/PATCH-RFC-builtin-tag-c-move-PGP-verification-inside-builtin-td7651529.html#a7651547
[2] http://git.661346.n2.nabble.com/PATCH-tag-c-move-PGP-verification-code-from-plumbing-td7651562.html 

             reply	other threads:[~2016-04-02 23:16 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-02 23:16 santiago [this message]
2016-04-02 23:16 ` [PATCH v3 1/4] builtin/verify-tag.c: Ignore SIGPIPE on gpg-interface santiago
2016-04-03  4:30   ` Jeff King
2016-04-03  6:50   ` Johannes Sixt
2016-04-03 21:46     ` Santiago Torres
2016-04-02 23:16 ` [PATCH v3 2/4] t/t7030-verify-tag.sh: Adds validation for multiple tags santiago
2016-04-03  4:40   ` Jeff King
2016-04-03  7:59     ` Eric Sunshine
2016-04-03 13:07       ` Jeff King
2016-04-03 21:58         ` Santiago Torres
2016-04-04  1:38           ` Eric Sunshine
2016-04-04 13:41             ` Jeff King
2016-04-02 23:16 ` [PATCH v3 3/4] builtin/verify-tag: move verification code to tag.c santiago
2016-04-03  4:45   ` Jeff King
2016-04-03  8:11     ` Eric Sunshine
2016-04-03  8:19   ` Eric Sunshine
2016-04-03 21:53     ` Santiago Torres
2016-04-02 23:16 ` [PATCH v3 4/4] tag: use pgp_verify_function in tag -v call santiago
2016-04-03  4:56   ` Jeff King
2016-04-03 21:43     ` Santiago Torres
2016-04-04  4:12     ` Santiago Torres
2016-04-04 13:38       ` Jeff King
2016-04-04 18:24         ` Santiago Torres
2016-04-04 20:19           ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459638975-17705-1-git-send-email-santiago@nyu.edu \
    --to=santiago@nyu.edu \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).