From: Alexander Rinass <alex@fournova.com>
To: git@vger.kernel.org
Cc: "Torsten Bögershausen" <tboegi@web.de>,
"Alexander Rinass" <alex@fournova.com>
Subject: [PATCH] diff: run arguments through precompose_argv
Date: Mon, 4 Apr 2016 22:38:44 +0200 [thread overview]
Message-ID: <1459802325-22056-1-git-send-email-alex@fournova.com> (raw)
I found an issue where file paths containing decomposed unicode chars
are not converted to precomposed unicode form when passed to the diff
command family.
As a result, no diff is displayed.
With the help of Torsten Bögershausen and Junio C Hamano I came up
with the following patch to fix the issue.
Alexander Rinass (1):
diff: run arguments through precompose_argv
builtin/diff-files.c | 1 +
builtin/diff-index.c | 1 +
builtin/diff-tree.c | 2 ++
builtin/diff.c | 1 +
t/t3910-mac-os-precompose.sh | 42 ++++++++++++++++++++++++++++++++++++++++++
5 files changed, 47 insertions(+)
--
2.7.2
next reply other threads:[~2016-04-04 20:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 20:38 Alexander Rinass [this message]
2016-04-04 20:38 ` [PATCH] diff: run arguments through precompose_argv Alexander Rinass
2016-04-05 17:09 ` Junio C Hamano
2016-04-05 19:15 ` Johannes Sixt
2016-04-05 19:27 ` Torsten Bögershausen
2016-04-05 21:42 ` Junio C Hamano
2016-04-06 6:51 ` Alexander Rinass
2016-04-06 7:47 ` Torsten Bögershausen
2016-04-06 17:27 ` Junio C Hamano
2016-05-11 22:08 ` Junio C Hamano
2016-05-12 11:16 ` Alexander Rinass
2016-05-12 15:39 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459802325-22056-1-git-send-email-alex@fournova.com \
--to=alex@fournova.com \
--cc=git@vger.kernel.org \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).