git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Turner <dturner@twopensource.com>
To: git@vger.kernel.org, pclouds@gmail.co,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Ramsay Jones" <ramsay@ramsayjones.plus.com>
Cc: David Turner <dturner@twopensource.com>
Subject: [PATCH v4 14/16] index-helper: autorun mode
Date: Tue, 12 Apr 2016 20:33:07 -0400	[thread overview]
Message-ID: <1460507589-25525-15-git-send-email-dturner@twopensource.com> (raw)
In-Reply-To: <1460507589-25525-1-git-send-email-dturner@twopensource.com>

Soon, we'll want to automatically start index-helper, so we need
a mode that silently exits if it can't start up (either because
it's not in a git dir, or because another one is already running).

Signed-off-by: David Turner <dturner@twopensource.com>
---
 index-helper.c          | 29 +++++++++++++++++++++++------
 t/t7900-index-helper.sh |  8 ++++++++
 2 files changed, 31 insertions(+), 6 deletions(-)

diff --git a/index-helper.c b/index-helper.c
index dcb2041..3374263 100644
--- a/index-helper.c
+++ b/index-helper.c
@@ -449,8 +449,9 @@ static void request_kill(void)
 int main(int argc, char **argv)
 {
 	const char *prefix;
-	int idle_in_seconds = 600, detach = 0, kill = 0;
+	int idle_in_seconds = 600, detach = 0, kill = 0, autorun = 0;
 	int fd;
+	int nongit;
 	struct strbuf socket_path = STRBUF_INIT;
 	struct option options[] = {
 		OPT_INTEGER(0, "exit-after", &idle_in_seconds,
@@ -459,6 +460,7 @@ int main(int argc, char **argv)
 			 "verify shared memory after creating"),
 		OPT_BOOL(0, "detach", &detach, "detach the process"),
 		OPT_BOOL(0, "kill", &kill, "request that existing index helper processes exit"),
+		OPT_BOOL(0, "autorun", &autorun, "this is an automatic run of git index-helper, so certain errors can be solved by silently exiting"),
 		OPT_END()
 	};
 
@@ -468,7 +470,14 @@ int main(int argc, char **argv)
 	if (argc == 2 && !strcmp(argv[1], "-h"))
 		usage_with_options(usage_text, options);
 
-	prefix = setup_git_directory();
+	prefix = setup_git_directory_gently(&nongit);
+	if (nongit) {
+		if (autorun)
+			exit(0);
+		else
+			die(_("not a git repository"));
+	}
+
 	if (parse_options(argc, (const char **)argv, prefix,
 			  options, usage_text, 0))
 		die(_("too many arguments"));
@@ -482,10 +491,18 @@ int main(int argc, char **argv)
 
 	/* check that no other copy is running */
 	fd = connect_to_index_helper();
-	if (fd > 0)
-		die(_("Already running"));
-	if (errno != ECONNREFUSED && errno != ENOENT)
-		die_errno(_("Unexpected error checking socket"));
+	if (fd > 0) {
+		if (autorun)
+			exit(0);
+		else
+			die(_("Already running"));
+	}
+	if (errno != ECONNREFUSED && errno != ENOENT) {
+		if (autorun)
+			return 0;
+		else
+			die_errno(_("Unexpected error checking socket"));
+	}
 
 	atexit(cleanup);
 	sigchain_push_common(cleanup_on_signal);
diff --git a/t/t7900-index-helper.sh b/t/t7900-index-helper.sh
index 32ef6f7..eeca483 100755
--- a/t/t7900-index-helper.sh
+++ b/t/t7900-index-helper.sh
@@ -41,4 +41,12 @@ test_expect_success 'index-helper will not start if already running' '
 	grep "Already running" err
 '
 
+test_expect_success 'index-helper is quiet with --autorun' '
+	test_when_finished "git index-helper --kill" &&
+	git index-helper --kill &&
+	git index-helper --detach &&
+	test -L .git/index-helper.path &&
+	git index-helper --autorun
+'
+
 test_done
-- 
2.4.2.767.g62658d5-twtrsrc

  parent reply	other threads:[~2016-04-13  0:34 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-13  0:32 [PATCH v4 00/16] index-helper, watchman David Turner
2016-04-13  0:32 ` [PATCH v4 01/16] read-cache.c: fix constness of verify_hdr() David Turner
2016-04-13  0:32 ` [PATCH v4 02/16] read-cache: allow to keep mmap'd memory after reading David Turner
2016-04-13  0:32 ` [PATCH v4 03/16] index-helper: new daemon for caching index and related stuff David Turner
2016-04-13 13:43   ` Duy Nguyen
2016-04-13 18:47     ` David Turner
2016-04-14 10:04       ` Duy Nguyen
2016-04-15 20:19         ` David Turner
2016-04-15 11:25       ` Duy Nguyen
2016-04-15 20:21         ` David Turner
2016-04-16  0:22           ` Duy Nguyen
2016-04-13 17:00   ` Ramsay Jones
2016-04-13 17:10     ` David Turner
2016-04-14 16:56   ` Junio C Hamano
2016-04-14 17:02     ` David Turner
2016-04-15  0:07       ` Duy Nguyen
2016-04-16  0:04   ` Stefan Beller
2016-04-19 22:00     ` David Turner
2016-04-19 22:00     ` David Turner
2016-04-13  0:32 ` [PATCH v4 04/16] index-helper: add --strict David Turner
2016-04-13  0:32 ` [PATCH v4 05/16] daemonize(): set a flag before exiting the main process David Turner
2016-04-13  0:32 ` [PATCH v4 06/16] index-helper: add --detach David Turner
2016-04-13  0:33 ` [PATCH v4 07/16] read-cache: add watchman 'WAMA' extension David Turner
2016-04-13  0:33 ` [PATCH v4 08/16] Add watchman support to reduce index refresh cost David Turner
2016-04-17  5:36   ` Duy Nguyen
2016-04-13  0:33 ` [PATCH v4 09/16] index-helper: use watchman to avoid refreshing index with lstat() David Turner
2016-04-16  0:07   ` Stefan Beller
2016-04-19 18:54     ` David Turner
2016-04-13  0:33 ` [PATCH v4 10/16] update-index: enable/disable watchman support David Turner
2016-04-13  0:33 ` [PATCH v4 11/16] unpack-trees: preserve index extensions David Turner
2016-04-13  0:33 ` [PATCH v4 12/16] index-helper: kill mode David Turner
2016-04-16 16:08   ` Ævar Arnfjörð Bjarmason
2016-04-19 22:14     ` David Turner
2016-04-13  0:33 ` [PATCH v4 13/16] index-helper: don't run if already running David Turner
2016-04-13  0:33 ` David Turner [this message]
2016-04-13  0:33 ` [PATCH v4 15/16] index-helper: optionally automatically run David Turner
2016-04-17  5:19   ` Duy Nguyen
2016-04-19 22:31     ` David Turner
2016-04-13  0:33 ` [PATCH v4 16/16] read-cache: config for waiting for index-helper David Turner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1460507589-25525-15-git-send-email-dturner@twopensource.com \
    --to=dturner@twopensource.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.co \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).