git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Turner <dturner@twopensource.com>
To: git@vger.kernel.org, pclouds@gmail.co,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Ramsay Jones" <ramsay@ramsayjones.plus.com>
Cc: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
	"David Turner" <dturner@twopensource.com>
Subject: [PATCH v4 02/16] read-cache: allow to keep mmap'd memory after reading
Date: Tue, 12 Apr 2016 20:32:55 -0400	[thread overview]
Message-ID: <1460507589-25525-3-git-send-email-dturner@twopensource.com> (raw)
In-Reply-To: <1460507589-25525-1-git-send-email-dturner@twopensource.com>

From: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>

Later, we will introduce git index-helper to share this memory with
other git processes.

Since the memory will be shared, it will never be unmapped (although
the kernel may of course choose to page it out).

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: David Turner <dturner@twopensource.com>
---
 cache.h      |  3 +++
 read-cache.c | 13 ++++++++++++-
 2 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/cache.h b/cache.h
index b829410..4180e2b 100644
--- a/cache.h
+++ b/cache.h
@@ -333,11 +333,14 @@ struct index_state {
 	struct split_index *split_index;
 	struct cache_time timestamp;
 	unsigned name_hash_initialized : 1,
+		 keep_mmap : 1,
 		 initialized : 1;
 	struct hashmap name_hash;
 	struct hashmap dir_hash;
 	unsigned char sha1[20];
 	struct untracked_cache *untracked;
+	void *mmap;
+	size_t mmap_size;
 };
 
 extern struct index_state the_index;
diff --git a/read-cache.c b/read-cache.c
index 16cc487..7e387e9 100644
--- a/read-cache.c
+++ b/read-cache.c
@@ -1574,6 +1574,10 @@ int do_read_index(struct index_state *istate, const char *path, int must_exist)
 	mmap = xmmap(NULL, mmap_size, PROT_READ, MAP_PRIVATE, fd, 0);
 	if (mmap == MAP_FAILED)
 		die_errno("unable to map index file");
+	if (istate->keep_mmap) {
+		istate->mmap = mmap;
+		istate->mmap_size = mmap_size;
+	}
 	close(fd);
 
 	hdr = mmap;
@@ -1626,10 +1630,12 @@ int do_read_index(struct index_state *istate, const char *path, int must_exist)
 		src_offset += 8;
 		src_offset += extsize;
 	}
-	munmap(mmap, mmap_size);
+	if (!istate->keep_mmap)
+		munmap(mmap, mmap_size);
 	return istate->cache_nr;
 
 unmap:
+	istate->mmap = NULL;
 	munmap(mmap, mmap_size);
 	die("index file corrupt");
 }
@@ -1655,6 +1661,7 @@ int read_index_from(struct index_state *istate, const char *path)
 		discard_index(split_index->base);
 	else
 		split_index->base = xcalloc(1, sizeof(*split_index->base));
+	split_index->base->keep_mmap = istate->keep_mmap;
 	ret = do_read_index(split_index->base,
 			    git_path("sharedindex.%s",
 				     sha1_to_hex(split_index->base_sha1)), 1);
@@ -1698,6 +1705,10 @@ int discard_index(struct index_state *istate)
 	free(istate->cache);
 	istate->cache = NULL;
 	istate->cache_alloc = 0;
+	if (istate->keep_mmap && istate->mmap) {
+		munmap(istate->mmap, istate->mmap_size);
+		istate->mmap = NULL;
+	}
 	discard_split_index(istate);
 	free_untracked_cache(istate->untracked);
 	istate->untracked = NULL;
-- 
2.4.2.767.g62658d5-twtrsrc

  parent reply	other threads:[~2016-04-13  0:33 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-13  0:32 [PATCH v4 00/16] index-helper, watchman David Turner
2016-04-13  0:32 ` [PATCH v4 01/16] read-cache.c: fix constness of verify_hdr() David Turner
2016-04-13  0:32 ` David Turner [this message]
2016-04-13  0:32 ` [PATCH v4 03/16] index-helper: new daemon for caching index and related stuff David Turner
2016-04-13 13:43   ` Duy Nguyen
2016-04-13 18:47     ` David Turner
2016-04-14 10:04       ` Duy Nguyen
2016-04-15 20:19         ` David Turner
2016-04-15 11:25       ` Duy Nguyen
2016-04-15 20:21         ` David Turner
2016-04-16  0:22           ` Duy Nguyen
2016-04-13 17:00   ` Ramsay Jones
2016-04-13 17:10     ` David Turner
2016-04-14 16:56   ` Junio C Hamano
2016-04-14 17:02     ` David Turner
2016-04-15  0:07       ` Duy Nguyen
2016-04-16  0:04   ` Stefan Beller
2016-04-19 22:00     ` David Turner
2016-04-19 22:00     ` David Turner
2016-04-13  0:32 ` [PATCH v4 04/16] index-helper: add --strict David Turner
2016-04-13  0:32 ` [PATCH v4 05/16] daemonize(): set a flag before exiting the main process David Turner
2016-04-13  0:32 ` [PATCH v4 06/16] index-helper: add --detach David Turner
2016-04-13  0:33 ` [PATCH v4 07/16] read-cache: add watchman 'WAMA' extension David Turner
2016-04-13  0:33 ` [PATCH v4 08/16] Add watchman support to reduce index refresh cost David Turner
2016-04-17  5:36   ` Duy Nguyen
2016-04-13  0:33 ` [PATCH v4 09/16] index-helper: use watchman to avoid refreshing index with lstat() David Turner
2016-04-16  0:07   ` Stefan Beller
2016-04-19 18:54     ` David Turner
2016-04-13  0:33 ` [PATCH v4 10/16] update-index: enable/disable watchman support David Turner
2016-04-13  0:33 ` [PATCH v4 11/16] unpack-trees: preserve index extensions David Turner
2016-04-13  0:33 ` [PATCH v4 12/16] index-helper: kill mode David Turner
2016-04-16 16:08   ` Ævar Arnfjörð Bjarmason
2016-04-19 22:14     ` David Turner
2016-04-13  0:33 ` [PATCH v4 13/16] index-helper: don't run if already running David Turner
2016-04-13  0:33 ` [PATCH v4 14/16] index-helper: autorun mode David Turner
2016-04-13  0:33 ` [PATCH v4 15/16] index-helper: optionally automatically run David Turner
2016-04-17  5:19   ` Duy Nguyen
2016-04-19 22:31     ` David Turner
2016-04-13  0:33 ` [PATCH v4 16/16] read-cache: config for waiting for index-helper David Turner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1460507589-25525-3-git-send-email-dturner@twopensource.com \
    --to=dturner@twopensource.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.co \
    --cc=pclouds@gmail.com \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).