From: David Turner <dturner@twopensource.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, pclouds@gmail.co,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Ramsay Jones" <ramsay@ramsayjones.plus.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: Re: [PATCH v4 03/16] index-helper: new daemon for caching index and related stuff
Date: Thu, 14 Apr 2016 13:02:12 -0400 [thread overview]
Message-ID: <1460653332.5540.84.camel@twopensource.com> (raw)
In-Reply-To: <xmqqy48ggmcs.fsf@gitster.mtv.corp.google.com>
On Thu, 2016-04-14 at 09:56 -0700, Junio C Hamano wrote:
> David Turner <dturner@twopensource.com> writes:
>
> > $GIT_DIR/index-helper.path is a symlink to the socket for the
> > daemon
> > process. The daemon reads from the socket and executes commands.
>
> We generally avoid using symbolic links inside $GIT_DIR (we used to
> represent the current branch by a symbolic link HEAD pointing at the
> underlying ref, but switched to the textual symref long time ago,
> and we did the ".git pointing at the real repository location" to
> support submodules also in a similar way).
>
> I wonder if we can change this to a file that records the location
> of the socket without bending over backwards too much?
>
> > Named pipes were considered for portability reasons, but then
> > commands
> > that need replies from the daemon would have open their own pipes,
> > since a named pipe should only have one reader. Unix domain
> > sockets
> > don't have this problem.
> >
> > On webkit.git with index format v2, duplicating 8 times to 1.4m
> > entries and 200MB in size:
> >
> > (vanilla) 0.986986364 s: read_index_from .git/index
> > (index-helper) 0.267850279 s: read_index_from .git/index
> >
> > Interestingly with index v4, we get less out of index-helper. It
> > makes
> > sense as v4 requires more processing after loading the index:
> >
> > (vanilla) 0.722496666 s: read_index_from .git/index
> > (index-helper) 0.302741500 s: read_index_from .git/index
> >
> > (these benchmarks are from an earlier version of this patch, but
> > should
> > still be valid).
>
> Just something to keep in mind; we'd need to see updated numbers
> when the series matures.
I don't actually know how Duy did the index duplication for this
benchmark. Duy?
next prev parent reply other threads:[~2016-04-14 17:02 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 0:32 [PATCH v4 00/16] index-helper, watchman David Turner
2016-04-13 0:32 ` [PATCH v4 01/16] read-cache.c: fix constness of verify_hdr() David Turner
2016-04-13 0:32 ` [PATCH v4 02/16] read-cache: allow to keep mmap'd memory after reading David Turner
2016-04-13 0:32 ` [PATCH v4 03/16] index-helper: new daemon for caching index and related stuff David Turner
2016-04-13 13:43 ` Duy Nguyen
2016-04-13 18:47 ` David Turner
2016-04-14 10:04 ` Duy Nguyen
2016-04-15 20:19 ` David Turner
2016-04-15 11:25 ` Duy Nguyen
2016-04-15 20:21 ` David Turner
2016-04-16 0:22 ` Duy Nguyen
2016-04-13 17:00 ` Ramsay Jones
2016-04-13 17:10 ` David Turner
2016-04-14 16:56 ` Junio C Hamano
2016-04-14 17:02 ` David Turner [this message]
2016-04-15 0:07 ` Duy Nguyen
2016-04-16 0:04 ` Stefan Beller
2016-04-19 22:00 ` David Turner
2016-04-19 22:00 ` David Turner
2016-04-13 0:32 ` [PATCH v4 04/16] index-helper: add --strict David Turner
2016-04-13 0:32 ` [PATCH v4 05/16] daemonize(): set a flag before exiting the main process David Turner
2016-04-13 0:32 ` [PATCH v4 06/16] index-helper: add --detach David Turner
2016-04-13 0:33 ` [PATCH v4 07/16] read-cache: add watchman 'WAMA' extension David Turner
2016-04-13 0:33 ` [PATCH v4 08/16] Add watchman support to reduce index refresh cost David Turner
2016-04-17 5:36 ` Duy Nguyen
2016-04-13 0:33 ` [PATCH v4 09/16] index-helper: use watchman to avoid refreshing index with lstat() David Turner
2016-04-16 0:07 ` Stefan Beller
2016-04-19 18:54 ` David Turner
2016-04-13 0:33 ` [PATCH v4 10/16] update-index: enable/disable watchman support David Turner
2016-04-13 0:33 ` [PATCH v4 11/16] unpack-trees: preserve index extensions David Turner
2016-04-13 0:33 ` [PATCH v4 12/16] index-helper: kill mode David Turner
2016-04-16 16:08 ` Ævar Arnfjörð Bjarmason
2016-04-19 22:14 ` David Turner
2016-04-13 0:33 ` [PATCH v4 13/16] index-helper: don't run if already running David Turner
2016-04-13 0:33 ` [PATCH v4 14/16] index-helper: autorun mode David Turner
2016-04-13 0:33 ` [PATCH v4 15/16] index-helper: optionally automatically run David Turner
2016-04-17 5:19 ` Duy Nguyen
2016-04-19 22:31 ` David Turner
2016-04-13 0:33 ` [PATCH v4 16/16] read-cache: config for waiting for index-helper David Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460653332.5540.84.camel@twopensource.com \
--to=dturner@twopensource.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.co \
--cc=pclouds@gmail.com \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).