From: santiago@nyu.edu
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
Eric Sunshine <sunshine@sunshineco.com>,
Santiago Torres <santiago@nyu.edu>
Subject: [PATCH v6 3/6] verify-tag: change variable name for readability
Date: Sun, 17 Apr 2016 18:26:58 -0400 [thread overview]
Message-ID: <1460932021-27633-4-git-send-email-santiago@nyu.edu> (raw)
In-Reply-To: <1460932021-27633-1-git-send-email-santiago@nyu.edu>
From: Santiago Torres <santiago@nyu.edu>
The run_gpg_verify() function has two variables, size and len.
This may come off as confusing when reading the code. Clarify which
one pertains to the length of the tag headers by renaming len to
payload_length.
Signed-off-by: Santiago Torres <santiago@nyu.edu>
Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
builtin/verify-tag.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/builtin/verify-tag.c b/builtin/verify-tag.c
index 77f070a..010353c 100644
--- a/builtin/verify-tag.c
+++ b/builtin/verify-tag.c
@@ -21,20 +21,21 @@ static const char * const verify_tag_usage[] = {
static int run_gpg_verify(const char *buf, unsigned long size, unsigned flags)
{
struct signature_check sigc;
- int len;
+ int payload_size;
int ret;
memset(&sigc, 0, sizeof(sigc));
- len = parse_signature(buf, size);
+ payload_size = parse_signature(buf, size);
- if (size == len) {
+ if (size == payload_size) {
if (flags & GPG_VERIFY_VERBOSE)
- write_in_full(1, buf, len);
+ write_in_full(1, buf, payload_size);
return error("no signature found");
}
- ret = check_signature(buf, len, buf + len, size - len, &sigc);
+ ret = check_signature(buf, payload_size, buf + payload_size,
+ size - payload_size, &sigc);
print_signature_buffer(&sigc, flags);
signature_check_clear(&sigc);
--
2.8.0
next prev parent reply other threads:[~2016-04-17 22:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-17 22:26 [PATCH v6 0/6] Move PGP verification out of verify-tag santiago
2016-04-17 22:26 ` [PATCH v6 1/6] builtin/verify-tag.c: ignore SIGPIPE in gpg-interface santiago
2016-04-17 22:26 ` [PATCH v6 2/6] t7030: test verifying multiple tags santiago
2016-04-17 22:26 ` santiago [this message]
2016-04-18 17:20 ` [PATCH v6 3/6] verify-tag: change variable name for readability Eric Sunshine
2016-04-19 5:13 ` Jeff King
2016-04-17 22:26 ` [PATCH v6 4/6] verify-tag: add sha1 argument to verify_tag() santiago
2016-04-18 17:41 ` Eric Sunshine
2016-04-18 20:28 ` Junio C Hamano
2016-04-17 22:27 ` [PATCH v6 5/6] verify-tag: move verification code to tag.c santiago
2016-04-17 22:27 ` [PATCH v6 6/6] tag -v: verfy directly rather than exec-ing verify-tag santiago
2016-04-18 18:00 ` Eric Sunshine
2016-04-18 18:14 ` [PATCH v6 0/6] Move PGP verification out of verify-tag Eric Sunshine
2016-04-18 20:15 ` Junio C Hamano
2016-04-19 5:16 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460932021-27633-4-git-send-email-santiago@nyu.edu \
--to=santiago@nyu.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).