git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: santiago@nyu.edu
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
	Eric Sunshine <sunshine@sunshineco.com>,
	Santiago Torres <santiago@nyu.edu>
Subject: [PATCH v6 6/6] tag -v: verfy directly rather than exec-ing verify-tag
Date: Sun, 17 Apr 2016 18:27:01 -0400	[thread overview]
Message-ID: <1460932021-27633-7-git-send-email-santiago@nyu.edu> (raw)
In-Reply-To: <1460932021-27633-1-git-send-email-santiago@nyu.edu>

From: Santiago Torres <santiago@nyu.edu>

tag -v forks into verify-tag, which only calls gpg_verify_tag().

Instead of forking to verify-tag, call gpg_verify_tag directly().

Helped-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Santiago Torres <santiago@nyu.edu>
---
 builtin/tag.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/builtin/tag.c b/builtin/tag.c
index 1705c94..7b2918e 100644
--- a/builtin/tag.c
+++ b/builtin/tag.c
@@ -104,13 +104,7 @@ static int delete_tag(const char *name, const char *ref,
 static int verify_tag(const char *name, const char *ref,
 				const unsigned char *sha1)
 {
-	const char *argv_verify_tag[] = {"verify-tag",
-					"-v", "SHA1_HEX", NULL};
-	argv_verify_tag[2] = sha1_to_hex(sha1);
-
-	if (run_command_v_opt(argv_verify_tag, RUN_GIT_CMD))
-		return error(_("could not verify the tag '%s'"), name);
-	return 0;
+	return gpg_verify_tag(sha1, name, GPG_VERIFY_VERBOSE);
 }
 
 static int do_sign(struct strbuf *buffer)
-- 
2.8.0

  parent reply	other threads:[~2016-04-17 22:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-17 22:26 [PATCH v6 0/6] Move PGP verification out of verify-tag santiago
2016-04-17 22:26 ` [PATCH v6 1/6] builtin/verify-tag.c: ignore SIGPIPE in gpg-interface santiago
2016-04-17 22:26 ` [PATCH v6 2/6] t7030: test verifying multiple tags santiago
2016-04-17 22:26 ` [PATCH v6 3/6] verify-tag: change variable name for readability santiago
2016-04-18 17:20   ` Eric Sunshine
2016-04-19  5:13   ` Jeff King
2016-04-17 22:26 ` [PATCH v6 4/6] verify-tag: add sha1 argument to verify_tag() santiago
2016-04-18 17:41   ` Eric Sunshine
2016-04-18 20:28     ` Junio C Hamano
2016-04-17 22:27 ` [PATCH v6 5/6] verify-tag: move verification code to tag.c santiago
2016-04-17 22:27 ` santiago [this message]
2016-04-18 18:00   ` [PATCH v6 6/6] tag -v: verfy directly rather than exec-ing verify-tag Eric Sunshine
2016-04-18 18:14 ` [PATCH v6 0/6] Move PGP verification out of verify-tag Eric Sunshine
2016-04-18 20:15 ` Junio C Hamano
2016-04-19  5:16 ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1460932021-27633-7-git-send-email-santiago@nyu.edu \
    --to=santiago@nyu.edu \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).